From 06a0b2d6b2a118f4b11f09770f59611d4483a1c4 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Wed, 11 Dec 2024 13:53:02 +0000 Subject: [PATCH 1/2] feat(node): Remove `processThreadBreadcrumbIntegration` --- .../node-exports-test-app/scripts/consistentExports.ts | 2 -- packages/astro/src/index.server.ts | 2 -- packages/aws-serverless/src/index.ts | 2 -- packages/google-cloud-serverless/src/index.ts | 2 -- packages/node/src/index.ts | 2 -- packages/node/src/integrations/childProcess.ts | 7 ------- 6 files changed, 17 deletions(-) diff --git a/dev-packages/e2e-tests/test-applications/node-exports-test-app/scripts/consistentExports.ts b/dev-packages/e2e-tests/test-applications/node-exports-test-app/scripts/consistentExports.ts index 83f9c1639cdc..8c3e51b14024 100644 --- a/dev-packages/e2e-tests/test-applications/node-exports-test-app/scripts/consistentExports.ts +++ b/dev-packages/e2e-tests/test-applications/node-exports-test-app/scripts/consistentExports.ts @@ -50,8 +50,6 @@ const DEPENDENTS: Dependent[] = [ ignoreExports: [ // not supported in bun: 'NodeClient', - // Bun doesn't emit the required diagnostics_channel events - 'processThreadBreadcrumbIntegration', 'childProcessIntegration', ], }, diff --git a/packages/astro/src/index.server.ts b/packages/astro/src/index.server.ts index 7eca9de9a41a..c628bb7605ff 100644 --- a/packages/astro/src/index.server.ts +++ b/packages/astro/src/index.server.ts @@ -97,8 +97,6 @@ export { parameterize, postgresIntegration, prismaIntegration, - // eslint-disable-next-line deprecation/deprecation - processThreadBreadcrumbIntegration, childProcessIntegration, redisIntegration, requestDataIntegration, diff --git a/packages/aws-serverless/src/index.ts b/packages/aws-serverless/src/index.ts index 3f167b62a7e3..a4f7f378ed8b 100644 --- a/packages/aws-serverless/src/index.ts +++ b/packages/aws-serverless/src/index.ts @@ -110,8 +110,6 @@ export { setupNestErrorHandler, postgresIntegration, prismaIntegration, - // eslint-disable-next-line deprecation/deprecation - processThreadBreadcrumbIntegration, childProcessIntegration, hapiIntegration, setupHapiErrorHandler, diff --git a/packages/google-cloud-serverless/src/index.ts b/packages/google-cloud-serverless/src/index.ts index 6f89769c2a37..d23c78f412d9 100644 --- a/packages/google-cloud-serverless/src/index.ts +++ b/packages/google-cloud-serverless/src/index.ts @@ -123,8 +123,6 @@ export { zodErrorsIntegration, profiler, amqplibIntegration, - // eslint-disable-next-line deprecation/deprecation - processThreadBreadcrumbIntegration, childProcessIntegration, } from '@sentry/node'; diff --git a/packages/node/src/index.ts b/packages/node/src/index.ts index fa16ac4e6b3d..7eeb71a765df 100644 --- a/packages/node/src/index.ts +++ b/packages/node/src/index.ts @@ -34,8 +34,6 @@ export { tediousIntegration } from './integrations/tracing/tedious'; export { genericPoolIntegration } from './integrations/tracing/genericPool'; export { dataloaderIntegration } from './integrations/tracing/dataloader'; export { amqplibIntegration } from './integrations/tracing/amqplib'; -// eslint-disable-next-line deprecation/deprecation -export { processThreadBreadcrumbIntegration, childProcessIntegration } from './integrations/childProcess'; export { SentryContextManager } from './otel/contextManager'; export { generateInstrumentOnce } from './otel/instrument'; diff --git a/packages/node/src/integrations/childProcess.ts b/packages/node/src/integrations/childProcess.ts index 99525b4092b4..e78cc843f279 100644 --- a/packages/node/src/integrations/childProcess.ts +++ b/packages/node/src/integrations/childProcess.ts @@ -39,13 +39,6 @@ export const childProcessIntegration = defineIntegration((options: Options = {}) }; }); -/** - * Capture breadcrumbs for child processes and worker threads. - * - * @deprecated Use `childProcessIntegration` integration instead. Functionally they are the same. `processThreadBreadcrumbIntegration` will be removed in the next major version. - */ -export const processThreadBreadcrumbIntegration = childProcessIntegration; - function captureChildProcessEvents(child: ChildProcess, options: Options): void { let hasExited = false; let data: Record | undefined; From 9bb0d4fe50451c879a9fec362117785047eabfde Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Thu, 12 Dec 2024 12:30:27 +0000 Subject: [PATCH 2/2] fix --- packages/node/src/index.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/node/src/index.ts b/packages/node/src/index.ts index 7eeb71a765df..71b1b80ffe82 100644 --- a/packages/node/src/index.ts +++ b/packages/node/src/index.ts @@ -34,6 +34,7 @@ export { tediousIntegration } from './integrations/tracing/tedious'; export { genericPoolIntegration } from './integrations/tracing/genericPool'; export { dataloaderIntegration } from './integrations/tracing/dataloader'; export { amqplibIntegration } from './integrations/tracing/amqplib'; +export { childProcessIntegration } from './integrations/childProcess'; export { SentryContextManager } from './otel/contextManager'; export { generateInstrumentOnce } from './otel/instrument';