From 04dffa3b18673b801652c9cee450c914ea4f10a9 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Fri, 2 Sep 2022 19:02:42 +0200 Subject: [PATCH 1/2] fix(tracing): Set sample rate in transaction metadata and DSC --- packages/tracing/src/hubextensions.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/tracing/src/hubextensions.ts b/packages/tracing/src/hubextensions.ts index 0884e7eaadab..88c016870c75 100644 --- a/packages/tracing/src/hubextensions.ts +++ b/packages/tracing/src/hubextensions.ts @@ -55,7 +55,10 @@ function sample( // if the user has forced a sampling decision by passing a `sampled` value in their transaction context, go with that if (transaction.sampled !== undefined) { transaction.setMetadata({ - transactionSampling: { method: 'explicitly_set' }, + transactionSampling: { + method: 'explicitly_set', + rate: Number(transaction.sampled), + }, }); return transaction; } From 7acff3afb3ebb2ce862b2ec077799f92f103465b Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Fri, 2 Sep 2022 19:21:58 +0200 Subject: [PATCH 2/2] fix test --- packages/tracing/test/hub.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/tracing/test/hub.test.ts b/packages/tracing/test/hub.test.ts index 5fe7d84066ab..559701ce64fb 100644 --- a/packages/tracing/test/hub.test.ts +++ b/packages/tracing/test/hub.test.ts @@ -243,7 +243,7 @@ describe('Hub', () => { hub.startTransaction({ name: 'dogpark', sampled: true }); expect(Transaction.prototype.setMetadata).toHaveBeenCalledWith({ - transactionSampling: { method: 'explicitly_set' }, + transactionSampling: { method: 'explicitly_set', rate: 1.0 }, }); });