From 94413567bcd02de3584d1a99a5d71f02dd9b9ef3 Mon Sep 17 00:00:00 2001 From: Billy Vong Date: Fri, 26 May 2023 10:13:21 -0400 Subject: [PATCH] test(replay): Skip firefox for flakey tests These tests seem to only flake on firefox? --- .../suites/replay/sessionExpiry/test.ts | 5 +++-- .../suites/replay/slowClick/mutation/test.ts | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/browser-integration-tests/suites/replay/sessionExpiry/test.ts b/packages/browser-integration-tests/suites/replay/sessionExpiry/test.ts index f1765b2a3c22..bd303c9e68c3 100644 --- a/packages/browser-integration-tests/suites/replay/sessionExpiry/test.ts +++ b/packages/browser-integration-tests/suites/replay/sessionExpiry/test.ts @@ -14,8 +14,9 @@ import { // Session should expire after 2s - keep in sync with init.js const SESSION_TIMEOUT = 2000; -sentryTest('handles an expired session', async ({ getLocalTestPath, page }) => { - if (shouldSkipReplayTest()) { +sentryTest('handles an expired session', async ({ browserName, getLocalTestPath, page }) => { + // This test seems to only be flakey on firefox + if (shouldSkipReplayTest() || ['firefox'].includes(browserName)) { sentryTest.skip(); } diff --git a/packages/browser-integration-tests/suites/replay/slowClick/mutation/test.ts b/packages/browser-integration-tests/suites/replay/slowClick/mutation/test.ts index 2ed458213955..d7b5800f9eea 100644 --- a/packages/browser-integration-tests/suites/replay/slowClick/mutation/test.ts +++ b/packages/browser-integration-tests/suites/replay/slowClick/mutation/test.ts @@ -63,8 +63,9 @@ sentryTest('mutation after threshold results in slow click', async ({ getLocalTe expect(slowClickBreadcrumbs[0]?.data?.timeAfterClickMs).toBeLessThan(2000); }); -sentryTest('immediate mutation does not trigger slow click', async ({ getLocalTestUrl, page }) => { - if (shouldSkipReplayTest()) { +sentryTest('immediate mutation does not trigger slow click', async ({ browserName, getLocalTestUrl, page }) => { + // This test seems to only be flakey on firefox + if (shouldSkipReplayTest() || ['firefox'].includes(browserName)) { sentryTest.skip(); }