From af636f090e2d09a28631d1f1ae9fb72135acffcb Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Mon, 28 Aug 2023 09:50:21 +0200 Subject: [PATCH 1/3] fix(replay): Better guard for `logger.info` Not sure if/why this should be required, but better safe then sorry I guess... Hopefully fixes https://github.com/getsentry/sentry-javascript/issues/8741 --- packages/replay/src/util/log.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/replay/src/util/log.ts b/packages/replay/src/util/log.ts index 9aa650a81264..0b3426e543c8 100644 --- a/packages/replay/src/util/log.ts +++ b/packages/replay/src/util/log.ts @@ -9,7 +9,7 @@ export function logInfo(message: string, shouldAddBreadcrumb?: boolean): void { return; } - logger.info(message); + __DEBUG_BUILD__ && logger.info(message); if (shouldAddBreadcrumb) { addBreadcrumb(message); @@ -25,7 +25,7 @@ export function logInfoNextTick(message: string, shouldAddBreadcrumb?: boolean): return; } - logger.info(message); + __DEBUG_BUILD__ && logger.info(message); if (shouldAddBreadcrumb) { // Wait a tick here to avoid race conditions for some initial logs From 96543ae0331facb877658b275bf136090a1ad449 Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Mon, 28 Aug 2023 10:17:04 +0200 Subject: [PATCH 2/3] better guard for logger info existence --- packages/replay/src/util/log.ts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/replay/src/util/log.ts b/packages/replay/src/util/log.ts index 0b3426e543c8..3231239206bb 100644 --- a/packages/replay/src/util/log.ts +++ b/packages/replay/src/util/log.ts @@ -9,7 +9,7 @@ export function logInfo(message: string, shouldAddBreadcrumb?: boolean): void { return; } - __DEBUG_BUILD__ && logger.info(message); + logMessage(message); if (shouldAddBreadcrumb) { addBreadcrumb(message); @@ -25,7 +25,7 @@ export function logInfoNextTick(message: string, shouldAddBreadcrumb?: boolean): return; } - __DEBUG_BUILD__ && logger.info(message); + logMessage(message); if (shouldAddBreadcrumb) { // Wait a tick here to avoid race conditions for some initial logs @@ -36,6 +36,11 @@ export function logInfoNextTick(message: string, shouldAddBreadcrumb?: boolean): } } +function logMessage(message: string): void { + // Not sure why this is necessary, but sometimes `logger.info` seems to be undefined + typeof logger.info === 'function' && logger.info(message); +} + function addBreadcrumb(message: string): void { const hub = getCurrentHub(); hub.addBreadcrumb( From 30054cbc8c8b2b2832be321d481e8732e09b4bd8 Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Mon, 28 Aug 2023 10:26:45 +0200 Subject: [PATCH 3/3] use `logger.log` instead of `logger.info` Maybe it is related to this... --- packages/replay/src/util/log.ts | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/packages/replay/src/util/log.ts b/packages/replay/src/util/log.ts index 3231239206bb..75361a99d33d 100644 --- a/packages/replay/src/util/log.ts +++ b/packages/replay/src/util/log.ts @@ -9,7 +9,7 @@ export function logInfo(message: string, shouldAddBreadcrumb?: boolean): void { return; } - logMessage(message); + logger.log(message); if (shouldAddBreadcrumb) { addBreadcrumb(message); @@ -25,7 +25,7 @@ export function logInfoNextTick(message: string, shouldAddBreadcrumb?: boolean): return; } - logMessage(message); + logger.log(message); if (shouldAddBreadcrumb) { // Wait a tick here to avoid race conditions for some initial logs @@ -36,11 +36,6 @@ export function logInfoNextTick(message: string, shouldAddBreadcrumb?: boolean): } } -function logMessage(message: string): void { - // Not sure why this is necessary, but sometimes `logger.info` seems to be undefined - typeof logger.info === 'function' && logger.info(message); -} - function addBreadcrumb(message: string): void { const hub = getCurrentHub(); hub.addBreadcrumb(