chore(js): Replace all instances of objectToArray with Object.entries (#14380)

Author: dashed

src/sentry/static/sentry/app/components/events/extraData.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 
-import {objectToArray} from 'app/utils';
 import {t} from 'app/locale';
 import ErrorBoundary from 'app/components/errorBoundary';
 import EventDataSection from 'app/components/events/eventDataSection';
@@ -30,7 +29,7 @@ class EventExtraData extends React.Component {
   };
 
   render() {
-    const extraDataArray = objectToArray(this.props.event.context);
+    const extraDataArray = Object.entries(this.props.event.context);
     return (
       <div className="extra-data">
         <EventDataSection

src/sentry/static/sentry/app/components/events/interfaces/cspContent.jsx

@@ -1,7 +1,6 @@
 import PropTypes from 'prop-types';
 import React from 'react';
 
-import {objectToArray} from 'app/utils';
 import KeyValueList from 'app/components/events/interfaces/keyValueList';
 
 class CSPContent extends React.Component {
@@ -16,7 +15,7 @@ class CSPContent extends React.Component {
         <h4>
           <span>{data.effective_directive}</span>
         </h4>
-        <KeyValueList data={objectToArray(data)} isContextData={true} />
+        <KeyValueList data={Object.entries(data)} isContextData={true} />
       </div>
     );
   }

src/sentry/static/sentry/app/components/events/interfaces/frameRegisters.jsx

@@ -5,7 +5,7 @@ import styled from 'react-emotion';
 
 import Tooltip from 'app/components/tooltip';
 import {t} from 'app/locale';
-import {defined, objectToArray} from 'app/utils';
+import {defined} from 'app/utils';
 
 const REGISTER_VIEWS = [t('Hexadecimal'), t('Numeric')];
 
@@ -68,7 +68,7 @@ class FrameRegisters extends React.Component {
   };
 
   render() {
-    const registers = objectToArray(this.props.data).filter(register =>
+    const registers = Object.entries(this.props.data).filter(register =>
       defined(register[1])
     );
 

src/sentry/static/sentry/app/components/events/interfaces/frameVariables.jsx

@@ -1,7 +1,6 @@
 import PropTypes from 'prop-types';
 import React from 'react';
 
-import {objectToArray} from 'app/utils';
 import KeyValueList from 'app/components/events/interfaces/keyValueList';
 
 class FrameVariables extends React.Component {
@@ -16,7 +15,7 @@ class FrameVariables extends React.Component {
   };
 
   render() {
-    const data = objectToArray(this.props.data);
+    const data = Object.entries(this.props.data);
 
     return (
       <KeyValueList data={data} isContextData={true} onClick={this.preventToggling} />

src/sentry/static/sentry/app/components/events/interfaces/generic.jsx

@@ -5,12 +5,11 @@ import SentryTypes from 'app/sentryTypes';
 import EventDataSection from 'app/components/events/eventDataSection';
 import KeyValueList from 'app/components/events/interfaces/keyValueList';
 import {t} from 'app/locale';
-import {objectToArray} from 'app/utils';
 
 function getView(view, data) {
   switch (view) {
     case 'report':
-      return <KeyValueList data={objectToArray(data)} isContextData={true} />;
+      return <KeyValueList data={Object.entries(data)} isContextData={true} />;
     case 'raw':
       return <pre>{JSON.stringify({'csp-report': data}, null, 2)}</pre>;
     default:

src/sentry/static/sentry/app/components/events/packageData.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 
-import {objectToArray} from 'app/utils';
 import {t} from 'app/locale';
 import ClippedBox from 'app/components/clippedBox';
 import ErrorBoundary from 'app/components/errorBoundary';
@@ -18,7 +17,7 @@ class EventPackageData extends React.Component {
   }
 
   render() {
-    const packages = objectToArray(this.props.event.packages);
+    const packages = Object.entries(this.props.event.packages);
 
     return (
       <EventDataSection event={this.props.event} type="packages" title={t('Packages')}>

src/sentry/static/sentry/app/components/modals/debugFileSourceModal.jsx

@@ -3,7 +3,6 @@ import React from 'react';
 
 import {t, tct} from 'app/locale';
 import SentryTypes from 'app/sentryTypes';
-import {objectToArray} from 'app/utils';
 import {
   AWS_REGIONS,
   DEBUG_SOURCE_LAYOUTS,
@@ -15,7 +14,7 @@ import Form from 'app/views/settings/components/forms/form';
 import FieldFromConfig from 'app/views/settings/components/forms/fieldFromConfig';
 
 function objectToChoices(obj) {
-  return objectToArray(obj).map(([key, value]) => [key, t(value)]);
+  return Object.entries(obj).map(([key, value]) => [key, t(value)]);
 }
 
 const commonFields = {

src/sentry/static/sentry/app/utils.tsx

@@ -62,9 +62,6 @@ function objectMatchesSubset(obj?: object, other?: object, deep?: boolean): bool
   return true;
 }
 
-// TODO: instances of objectToArray should be refactored
-export const objectToArray = Object.entries;
-
 export function intcomma(x: number): string {
   return x.toString().replace(/\B(?=(\d{3})+(?!\d))/g, ',');
 }

tests/js/spec/components/toggleRawEventData.spec.jsx

@@ -2,7 +2,6 @@ import React from 'react';
 import {shallow} from 'enzyme';
 import EventDataSection from 'app/components/events/eventDataSection';
 import KeyValueList from 'app/components/events/interfaces/keyValueList';
-import {objectToArray} from 'app/utils';
 
 const data = {
   metadata: {
@@ -63,7 +62,7 @@ describe('KeyValueList', function() {
     plussomeotherstuff: 'here',
     andthis: 0,
   };
-  const extraDataArray = objectToArray(context);
+  const extraDataArray = Object.entries(context);
 
   it('renders formatted', function() {
     const component = shallow(