fix(aci milestone 3): bug fix metric detector serializers #95920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #95920 +/- ##
==========================================
- Coverage 80.85% 80.85% -0.01%
==========================================
Files 10583 10585 +2
Lines 610030 610317 +287
Branches 23973 23973
==========================================
+ Hits 493248 493453 +205
- Misses 116074 116156 +82
Partials 708 708 |
iamrajjoshi
approved these changes
Jul 21, 2025
mifu67
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to incorrect querying, we were fetching all action filter data conditions in the database when attempting to serialize a detector :yikes:
Ultimately, the serialized response would be correct, because the data condition serializer had the correct filtering. However, on production data with many data conditions in the DB, the query would time out.