feat(aci): UI to filter monitors by assignee #95930
Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| export function useDetectorFilterKeys(): TagCollection { | ||
| const assignedValues = useAssignedSearchValues(); | ||
|
|
||
| return useMemo(() => { | ||
| return Object.fromEntries( | ||
| Object.keys(DETECTOR_FILTER_KEYS).map(key => { | ||
| const {values} = DETECTOR_FILTER_KEYS[key] ?? {}; | ||
|
|
||
| // Special handling for assignee field to provide user/team values | ||
| if (key === 'assignee') { | ||
| return [ | ||
| key, | ||
| { | ||
| key, | ||
| name: key, | ||
| predefined: true, | ||
| values: assignedValues, | ||
| }, | ||
| ]; | ||
| } | ||
|
|
||
| return [ | ||
| key, | ||
| { | ||
| key, | ||
| name: key, | ||
| predefined: values !== undefined, | ||
| values, | ||
| }, | ||
| ]; | ||
| }) | ||
| ); | ||
| }, [assignedValues]); | ||
| } |
There was a problem hiding this comment.
nit: felt like it was a little more concise using entries rather than keys and then inlining the checks for isAssignee.
export function useDetectorFilterKeys(): TagCollection {
const assignedValues = useAssignedSearchValues();
return useMemo(() => {
return Object.fromEntries(
Object.entries(DETECTOR_FILTER_KEYS).map(([key, config]) => {
const { values } = config ?? {};
const isAssignee = key === 'assignee';
return [key, {
key,
name: key,
predefined: isAssignee || values !== undefined,
values: isAssignee ? assignedValues : values,
}];
})
);
}, [assignedValues]);
}
|
Updated with a test and style nits. |
There was a problem hiding this comment.
Bug: Detector Filter Key Resolution Failure
The replacement of the custom getDetectorFilterKeyDefinition with the generic getFieldDefinition breaks field definition resolution for detector-specific filter keys. The original function was specifically designed to process DETECTOR_FILTER_KEYS and extract properties like description, valueType, keywords, and values to form correct field definitions. The generic getFieldDefinition lacks this specialized knowledge, which can impair search functionality, including autocomplete, validation, and keyword aliases for detector-specific keys such as 'name', 'type', and 'assignee'.
static/app/views/detectors/components/detectorSearch.tsx#L21-L22
sentry/static/app/views/detectors/components/detectorSearch.tsx
Lines 21 to 22 in 682e5c0
Was this report helpful? Give feedback by reacting with 👍 or 👎
|
Oops, I didn't know that "auto merge" would go in even when I re-requested review. |
Step 1
Step 2
Step 3