fix(aci): fix rule serializer lastTriggered to account for WorkflowFireHistory

[cathteng]

After we enable single processing, the last triggered field for the Rule in the serializer should also account for WorkflowFireHistory.

[iamrajjoshi]

smort

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #95939       +/-   ##
===========================================
+ Coverage   38.50%   87.78%   +49.27%     
===========================================
  Files        9955    10585      +630     
  Lines      557639   610023    +52384     
  Branches    23982    23982               
===========================================
+ Hits       214738   535520   +320782     
+ Misses     342617    74219   -268398     
  Partials      284      284               

[cathteng]

@iamrajjoshi cursor concern is legit so gonna fix it up before merge

[cursor]

Bug: Missing Keys in Lookup Cause Errors

A KeyError occurs when attempting to update last_triggered_lookup with WorkflowFireHistory data. The last_triggered_lookup dictionary is initially populated only with RuleFireHistory entries. If a rule has WorkflowFireHistory but no RuleFireHistory, its rule_id will be missing from last_triggered_lookup, causing a KeyError during direct access. Additionally, if existing_date is None, the comparison new_date > existing_date would result in a TypeError.

src/sentry/api/serializers/models/rule.py#L235-L239

sentry/src/sentry/api/serializers/models/rule.py

Lines 235 to 239 in e992fc2

	# Take the maximum date between RuleFireHistory and WorkflowFireHistory
	existing_date = last_triggered_lookup[rule_id]
	new_date = wfh["date_added"]
	if new_date > existing_date:
	last_triggered_lookup[rule_id] = new_date

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎