diff --git a/add-interactive.c b/add-interactive.c
index f0beeefa7953eb..b455c07d2fa7d9 100644
--- a/add-interactive.c
+++ b/add-interactive.c
@@ -138,15 +138,9 @@ struct list_and_choose_options {
 	void (*print_help)(struct add_i_state *s);
 };
 
-#define LIST_AND_CHOOSE_ERROR (-1)
-#define LIST_AND_CHOOSE_QUIT  (-2)
-
 /*
  * Returns the selected index in singleton mode, the number of selected items
  * otherwise.
- *
- * If an error occurred, returns `LIST_AND_CHOOSE_ERROR`. Upon EOF,
- * `LIST_AND_CHOOSE_QUIT` is returned.
  */
 static ssize_t list_and_choose(struct prefix_item **items, int *selected,
 			       size_t nr, struct add_i_state *s,
@@ -156,7 +150,7 @@ static ssize_t list_and_choose(struct prefix_item **items, int *selected,
 	int immediate = opts->flags & IMMEDIATE;
 
 	struct strbuf input = STRBUF_INIT;
-	ssize_t res = singleton ? LIST_AND_CHOOSE_ERROR : 0;
+	ssize_t res = singleton ? -1 : 0;
 
 	if (!selected && !singleton)
 		BUG("need a selected array in non-singleton mode");
@@ -180,7 +174,7 @@ static ssize_t list_and_choose(struct prefix_item **items, int *selected,
 		if (strbuf_getline(&input, stdin) == EOF) {
 			putchar('\n');
 			if (immediate)
-				res = LIST_AND_CHOOSE_QUIT;
+				res = -2;
 			break;
 		}
 		strbuf_trim(&input);
@@ -259,8 +253,7 @@ static ssize_t list_and_choose(struct prefix_item **items, int *selected,
 			p += sep + 1;
 		}
 
-		if ((immediate && res != LIST_AND_CHOOSE_ERROR) ||
-		    !strcmp(input.buf, "*"))
+		if ((immediate && res >= 0) || !strcmp(input.buf, "*"))
 			break;
 	}
 
@@ -1057,13 +1050,12 @@ int run_add_i(struct repository *r, const struct pathspec *ps)
 	for (;;) {
 		i = list_and_choose((struct prefix_item **)commands, NULL,
 				    ARRAY_SIZE(commands), &s, &main_loop_opts);
-		if (i == LIST_AND_CHOOSE_QUIT ||
-		    (i != LIST_AND_CHOOSE_ERROR && !commands[i]->command)) {
+		if (i < -1 || (i >= 0 && !commands[i]->command)) {
 			printf(_("Bye.\n"));
 			res = 0;
 			break;
 		}
-		if (i != LIST_AND_CHOOSE_ERROR)
+		if (i >= 0)
 			res = commands[i]->command(&s, ps, &files, &opts);
 	}
 
diff --git a/prefix-map.c b/prefix-map.c
index 747ddb4ebc8622..3c5ae4ae0aecb3 100644
--- a/prefix-map.c
+++ b/prefix-map.c
@@ -35,40 +35,40 @@ static void init_prefix_map(struct prefix_map *prefix_map,
 static void add_prefix_item(struct prefix_map *prefix_map,
 			    struct prefix_item *item)
 {
-	struct prefix_map_entry e = { { NULL } }, *e2;
+	struct prefix_map_entry *e = xmalloc(sizeof(*e)), *e2;
 	int j;
 
-	e.item = item;
-	e.name = item->name;
+	e->item = item;
+	e->name = e->item->name;
 
-	for (j = prefix_map->min_length;
-	     j <= prefix_map->max_length && e.name[j]; j++) {
-		/* Avoid breaking UTF-8 multi-byte sequences */
-		if (!isascii(e.name[j]))
+	for (j = prefix_map->min_length; j <= prefix_map->max_length; j++) {
+		if (!isascii(e->name[j])) {
+			free(e);
 			break;
+		}
 
-		e.prefix_length = j;
-		hashmap_entry_init(&e, memhash(e.name, j));
-		e2 = hashmap_get(&prefix_map->map, &e, NULL);
+		e->prefix_length = j;
+		hashmap_entry_init(e, memhash(e->name, j));
+		e2 = hashmap_get(&prefix_map->map, e, NULL);
 		if (!e2) {
-			/* prefix is unique at this stage */
-			item->prefix_length = j;
-			add_prefix_entry(&prefix_map->map, e.name, j, item);
+			/* prefix is unique so far */
+			e->item->prefix_length = j;
+			hashmap_add(&prefix_map->map, e);
 			break;
 		}
 
 		if (!e2->item)
 			continue; /* non-unique prefix */
 
-		if (j != e2->item->prefix_length || memcmp(e.name, e2->name, j))
-			BUG("unexpected prefix length: %d != %d (%s != %s)",
-			    j, (int)e2->item->prefix_length, e.name, e2->name);
+		if (j != e2->item->prefix_length)
+			BUG("unexpected prefix length: %d != %d",
+			    (int)j, (int)e2->item->prefix_length);
 
 		/* skip common prefix */
-		for (; j < prefix_map->max_length && e.name[j]; j++) {
-			if (e.item->name[j] != e2->item->name[j])
+		for (; j < prefix_map->max_length && e->name[j]; j++) {
+			if (e->item->name[j] != e2->item->name[j])
 				break;
-			add_prefix_entry(&prefix_map->map, e.name, j + 1,
+			add_prefix_entry(&prefix_map->map, e->name, j + 1,
 					 NULL);
 		}
 
@@ -83,14 +83,16 @@ static void add_prefix_item(struct prefix_map *prefix_map,
 			e2->item->prefix_length = 0;
 		e2->item = NULL;
 
-		if (j < prefix_map->max_length && e.name[j]) {
+		if (j < prefix_map->max_length && e->name[j]) {
 			/* found a unique prefix for the item */
-			e.item->prefix_length = j + 1;
-			add_prefix_entry(&prefix_map->map, e.name, j + 1,
-					 e.item);
-		} else
+			e->item->prefix_length = j + 1;
+			add_prefix_entry(&prefix_map->map, e->name, j + 1,
+					 e->item);
+		} else {
 			/* item has no (short enough) unique prefix */
-			e.item->prefix_length = 0;
+			e->item->prefix_length = 0;
+			free(e);
+		}
 
 		break;
 	}