Skip to content

Commit af1ac3b

Browse files
committed
mingw: enable stack smashing protector
To reduce Git for Windows' attack surface, we started using the Address Space Layout Randomization and Data Execution Prevention features in ce6a158 (mingw: enable DEP and ASLR, 2019-05-08). To remove yet another attack vector, let's make use of gcc's stack smashing protector that helps detect stack buffer overruns early. Rather than using -fstack-protector, we use -fstack-protector-strong because on Windows: The latter appears to strike a better balance between the performance impact and the provided safety. In a non-scientific test (time git log --grep=is -p), best of 5 timings went from 23.009s to 22.997s, i.e. the performance impact was *well* lost in the noise. This fixes git-for-windows#501 Signed-off-by: Johannes Schindelin <[email protected]>
1 parent aa25c82 commit af1ac3b

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

config.mak.uname

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,8 @@ else
596596
BASIC_LDFLAGS += -Wl,--large-address-aware
597597
endif
598598
CC = gcc
599-
COMPAT_CFLAGS += -D__USE_MINGW_ANSI_STDIO=0 -DDETECT_MSYS_TTY
599+
COMPAT_CFLAGS += -D__USE_MINGW_ANSI_STDIO=0 -DDETECT_MSYS_TTY \
600+
-fstack-protector-strong
600601
EXTLIBS += -lntdll
601602
INSTALL = /bin/install
602603
NO_R_TO_GCC_LINKER = YesPlease

0 commit comments

Comments
 (0)