Skip to content

Commit aee4fa7

Browse files
committed
Java: update extraction query tests after merging PR #13747
1 parent 134eeb1 commit aee4fa7

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

java/ql/src/Telemetry/AutomodelSharedCharacteristics.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ module SharedCharacteristics<CandidateSig Candidate> {
303303
* analyzed.
304304
*/
305305
private class IsSanitizerCharacteristic extends NotASinkCharacteristic {
306-
IsSanitizerCharacteristic() { this = "external" }
306+
IsSanitizerCharacteristic() { this = "known sanitizer" }
307307

308308
override predicate appliesToEndpoint(Candidate::Endpoint e) { Candidate::isSanitizer(e, _) }
309309
}

java/ql/test/query-tests/Telemetry/AutomodelApplicationModeExtractCandidates/Test.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ class AutomodelApplicationModeExtractCandidates {
1212
public static void main(String[] args) throws Exception {
1313
AtomicReference<String> reference = new AtomicReference<>(); // uninteresting (parameterless constructor)
1414
reference.set(args[0]); // arg[0] is not a candidate (modeled as value flow step)
15-
// ^^^^^^ Argument[this] is a candidate (should no longer be, once a recent PR
16-
// is merged)
15+
// ^^^^^^ Argument[this] is a candidate
1716
}
1817

1918
public static void callSupplier(Supplier<String> supplier) {
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
| Test.java:7:10:7:19 | ByteBuffer | class qualifier\nrelated locations: $@.\nmetadata: $@, $@, $@, $@, $@, $@. | Test.java:7:10:8:19 | allocate(...) | CallContext | file://java.nio:1:1:1:1 | java.nio | package | file://ByteBuffer:1:1:1:1 | ByteBuffer | type | file://false:1:1:1:1 | false | subtypes | file://allocate:1:1:1:1 | allocate | name | file://(int):1:1:1:1 | (int) | signature | file://Argument[this]:1:1:1:1 | Argument[this] | input |
2-
| Test.java:8:15:8:18 | size | external\nrelated locations: $@.\nmetadata: $@, $@, $@, $@, $@, $@. | Test.java:7:10:8:19 | allocate(...) | CallContext | file://java.nio:1:1:1:1 | java.nio | package | file://ByteBuffer:1:1:1:1 | ByteBuffer | type | file://false:1:1:1:1 | false | subtypes | file://allocate:1:1:1:1 | allocate | name | file://(int):1:1:1:1 | (int) | signature | file://Argument[0]:1:1:1:1 | Argument[0] | input |
1+
| Test.java:8:15:8:18 | size | known non-sink\nrelated locations: $@.\nmetadata: $@, $@, $@, $@, $@, $@. | Test.java:7:10:8:19 | allocate(...) | CallContext | file://java.nio:1:1:1:1 | java.nio | package | file://ByteBuffer:1:1:1:1 | ByteBuffer | type | file://false:1:1:1:1 | false | subtypes | file://allocate:1:1:1:1 | allocate | name | file://(int):1:1:1:1 | (int) | signature | file://Argument[0]:1:1:1:1 | Argument[0] | input |
2+
| Test.java:8:15:8:18 | size | known sanitizer\nrelated locations: $@.\nmetadata: $@, $@, $@, $@, $@, $@. | Test.java:7:10:8:19 | allocate(...) | CallContext | file://java.nio:1:1:1:1 | java.nio | package | file://ByteBuffer:1:1:1:1 | ByteBuffer | type | file://false:1:1:1:1 | false | subtypes | file://allocate:1:1:1:1 | allocate | name | file://(int):1:1:1:1 | (int) | signature | file://Argument[0]:1:1:1:1 | Argument[0] | input |

0 commit comments

Comments
 (0)