Skip to content

Commit c4b306b

Browse files
committed
addressing some review feedback
1 parent 7853366 commit c4b306b

File tree

2 files changed

+2
-16
lines changed

2 files changed

+2
-16
lines changed

components/dashboard/src/onboarding/StepOrgInfo.tsx

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -150,11 +150,6 @@ export const StepOrgInfo: FC<Props> = ({ user, onComplete }) => {
150150
}
151151
setJobRole(val);
152152
}}
153-
hint={
154-
jobRole !== JOB_ROLE_OTHER
155-
? "Please select the role that best describes the type of work you'll use Gitpod for"
156-
: ""
157-
}
158153
error={jobRoleError.message}
159154
onBlur={jobRoleError.onBlur}
160155
>
@@ -166,16 +161,7 @@ export const StepOrgInfo: FC<Props> = ({ user, onComplete }) => {
166161
</SelectInputField>
167162

168163
{jobRole === JOB_ROLE_OTHER && (
169-
<TextInputField
170-
value={jobRoleOther}
171-
onChange={setJobRoleOther}
172-
placeholder="Please share (optional)"
173-
hint={
174-
jobRole === JOB_ROLE_OTHER
175-
? "Please select the role that best describes the type of work you'll use Gitpod for"
176-
: ""
177-
}
178-
/>
164+
<TextInputField value={jobRoleOther} onChange={setJobRoleOther} placeholder="Please share (optional)" />
179165
)}
180166

181167
<TextInputField

components/dashboard/src/onboarding/job-roles.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export const getJobRoleOptions = () => {
1313
{ value: "data", label: "Data / Analytics" },
1414
{ value: "academics", label: "Academia (Student, Researcher)" },
1515
{ value: "enabling", label: "Platform or Developer Experience" },
16-
{ value: "team-lead", label: "A Team or Function Lead role" },
16+
{ value: "team-lead", label: "A Team Lead or Function Lead role" },
1717
{ value: "devrel", label: "DevRel" },
1818
{ value: "product-design", label: "Product" },
1919
{ value: JOB_ROLE_OTHER, label: "Other" },

0 commit comments

Comments
 (0)