Skip to content

Prep for new onboarding flow #16469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Prep for new onboarding flow #16469

merged 2 commits into from
Feb 21, 2023

Conversation

selfcontained
Copy link
Contributor

Description

Stubbing out a placeholder for the new onboarding flow. It's gated behind the newSignupFlow feature flag, which is off everywhere atm. When this is enabled, we'll also suppress existing onboarding flows, like IDE Selection, and Profile info nudging.

How to test

This PR shouldn't change any of the user experience.

  • Login as a new user in the preview environment
  • Verify you still see the IDE Selection after you login.

Release Notes

NONE

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-bmh-new-signup-flow-flagged.1 because the annotations in the pull request description changed
(with .werft/ from main)

@selfcontained selfcontained changed the title Bmh/new-signup-flow-flagged Prep for new onboarding flow Feb 18, 2023
@selfcontained selfcontained marked this pull request as ready for review February 18, 2023 14:51
@selfcontained selfcontained requested a review from a team February 18, 2023 14:51
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Feb 18, 2023
@selfcontained
Copy link
Contributor Author

/hold for feedback

@geropl
Copy link
Member

geropl commented Feb 21, 2023

/werft run

👍 started the job as gitpod-build-bmh-new-signup-flow-flagged.2
(with .werft/ from main)

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested and works ✔️

@selfcontained selfcontained force-pushed the bmh/new-signup-flow-flagged branch from 25f89de to d73eb89 Compare February 21, 2023 17:51
@selfcontained
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 8c25cea into main Feb 21, 2023
@roboquat roboquat deleted the bmh/new-signup-flow-flagged branch February 21, 2023 20:15
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants