Add What's New entry for teams and projects #5126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Associated issue: #5114 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gtsiolis
force-pushed
the
gt/add-entry-for-teams-and-projects
branch
from
99eac80 to
070219e
Compare
gtsiolis
commented
Aug 9, 2021
|
|
||
| import { User } from "@gitpod/gitpod-protocol"; | ||
| import { WhatsNewEntry } from "./WhatsNew"; | ||
| import { switchToVSCodeAction } from "./WhatsNew-2021-04"; |
There was a problem hiding this comment.
thought: I have no idea if this is needed. 😅
| </>; | ||
| }, | ||
| newsKey: 'August-2021', | ||
| maxUserCreationDate: '2021-08-17', |
There was a problem hiding this comment.
thought: Not sure what this does but I've added the target deployment date of next Tuesday (17.08.2021). 🐼
jankeromnes
changed the title
jankeromnes
reviewed
Sep 1, 2021
| return <> | ||
| <div className="border-t border-b border-gray-200 dark:border-gray-800 -mx-6 px-6 pt-6 pb-4"> | ||
| <p className="pb-2 text-gray-900 dark:text-gray-100 text-base font-medium">Teams & Projects <PillLabel>New Feature</PillLabel></p> | ||
| <p className="pb-2 text-gray-500 dark:text-gray-400 text-sm">Hey! We're introducing <strong>Teams & Projects</strong> to surface <strong>Prebuilds</strong> in the dashboard. All existing teams will be migrated over the upcoming weeks. No action is required on your side. 🎉</p> |
There was a problem hiding this comment.
Thoughts:
- "Hey!" is quite strong, maybe "Hi there!" is more cheerful and less "shouty"?
- All teams will be migrated "in the coming weeks" creates the wrong idea that this will happen very fast, and raises too many scary questions about billing etc. Probably safer to say the existing teams remain unchanged for now / might get migrated later "in due time"
Suggestion that you can apply in one click on GitHub:
Suggested change
| <p className="pb-2 text-gray-500 dark:text-gray-400 text-sm">Hey! We're introducing <strong>Teams & Projects</strong> to surface <strong>Prebuilds</strong> in the dashboard. All existing teams will be migrated over the upcoming weeks. No action is required on your side. 🎉</p> | |
| <p className="pb-2 text-gray-500 dark:text-gray-400 text-sm">Hi there! We're introducing <strong>Teams & Projects</strong> to surface <strong>Prebuilds</strong> in the dashboard. Existing team plans remain unchanged. No action is required on your side. 🎉</p> |
| <div className="border-t border-b border-gray-200 dark:border-gray-800 -mx-6 px-6 pt-6 pb-4"> | ||
| <p className="pb-2 text-gray-900 dark:text-gray-100 text-base font-medium">Teams & Projects <PillLabel>New Feature</PillLabel></p> | ||
| <p className="pb-2 text-gray-500 dark:text-gray-400 text-sm">Hey! We're introducing <strong>Teams & Projects</strong> to surface <strong>Prebuilds</strong> in the dashboard. All existing teams will be migrated over the upcoming weeks. No action is required on your side. 🎉</p> | ||
| <p className="pb-2 text-gray-500 dark:text-gray-400 text-sm">You can create as many teams as you need and import repositories as projects from the top navigation. 💡</p> |
There was a problem hiding this comment.
- Do our users really "need" a feature that hasn't existed until now? Maybe "want" is better.
- "repositories as projects" sounds a bit too complicated. Maybe just "projects"?
Suggested change
| <p className="pb-2 text-gray-500 dark:text-gray-400 text-sm">You can create as many teams as you need and import repositories as projects from the top navigation. 💡</p> | |
| <p className="pb-2 text-gray-500 dark:text-gray-400 text-sm">You can create as many teams as you want and import projects from the top navigation. 💡</p> |
| <p className="pb-2 text-gray-900 dark:text-gray-100 text-base font-medium">Teams & Projects <PillLabel>New Feature</PillLabel></p> | ||
| <p className="pb-2 text-gray-500 dark:text-gray-400 text-sm">Hey! We're introducing <strong>Teams & Projects</strong> to surface <strong>Prebuilds</strong> in the dashboard. All existing teams will be migrated over the upcoming weeks. No action is required on your side. 🎉</p> | ||
| <p className="pb-2 text-gray-500 dark:text-gray-400 text-sm">You can create as many teams as you need and import repositories as projects from the top navigation. 💡</p> | ||
| <p className="pb-2 text-gray-500 dark:text-gray-400 text-sm">We welcome any input on this first iteration in <a href="https://github.com/gitpod-io/gitpod/issues/5095" className="learn-more">the feedback issue</a>. 📝</p> |
There was a problem hiding this comment.
Please also link to the (upcoming) blog post to learn more, and add a screenshot e.g. like this one on Slack (internal)?
| }, | ||
| newsKey: 'August-2021', | ||
| maxUserCreationDate: '2021-08-17', | ||
| actionAfterSeen: switchToVSCodeAction, |
There was a problem hiding this comment.
Please remove this (this switches users from Theia to VSCode when they accept the Modal -- this is not relevant here)
gtsiolis
added
feature: teams and projects [DEPRECATED]
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add an entry in the What's New modal for the upcoming Teams & Projects feature.
Fix #5114.
First time adding an entry after the refactoring in #4607.⚠️