Lint fixes

Author: xlii-chl

models/issues/issue_search.go

@@ -144,13 +144,13 @@ func applyLabelsCondition(sess *xorm.Session, opts *IssuesOptions) *xorm.Session
 			// ... and use them in a subquery of the form :
 			//  where (select count(*) from issue_label where issue_id=issue.id and label_id in (2, 4, 6)) = 3
 			// This equality is garanteed thanks to unique index (issue_id,label_id) on table issue_label.
-			if (len(IncludedLabelIDs) > 0) {
+			if len(IncludedLabelIDs) > 0 {
 				subquery := builder.Select("count(*)").From("issue_label").Where(builder.Expr("issue_id = issue.id")).
 					And(builder.In("label_id", IncludedLabelIDs.Values()))
 				sess.Where(builder.Eq{strconv.Itoa(len(IncludedLabelIDs)): subquery})
 			}
 			// or (select count(*)...) = 0 for excluded labels
-			if (len(ExcludedLabelIDs) > 0) {
+			if len(ExcludedLabelIDs) > 0 {
 				subquery := builder.Select("count(*)").From("issue_label").Where(builder.Expr("issue_id = issue.id")).
 					And(builder.In("label_id", ExcludedLabelIDs.Values()))
 				sess.Where(builder.Eq{"0": subquery})

models/issues/label.go

@@ -151,7 +151,7 @@ func (l *Label) LoadSelectedLabelsAfterClick(currentSelectedLabels []int64, curr
 	// sort the ids to avoid the crawlers hitting the same
 	// page with a different order of parameters
 	// (still no sort.Ints64 in Go 1.20... Maybe Slice.sort in Go 1.21 ?)
-	sort.Slice(labelQuerySlice, func (i, j int) bool { return labelQuerySlice[i] < labelQuerySlice[j] })
+	sort.Slice(labelQuerySlice, func(i, j int) bool { return labelQuerySlice[i] < labelQuerySlice[j] })
 	// Deduplicate using a container
 	// (maybe again, with Go 1.21 and Slice.compact() ?)
 	labelQueryContainer := make(container.Set[string])

models/issues/label_test.go

@@ -36,7 +36,7 @@ func TestLabel_LoadSelectedLabelsAfterClick(t *testing.T) {
 	label.LoadSelectedLabelsAfterClick([]int64{1, 7, 1, 7, 7}, []string{"", "scope", "", "scope", "scope"})
 	// As of now, LoadSelectedLabelsAfterClick() use a map to deduplicate, which
 	// doesn't garanty the order
-	assert.Equal(t, true, "1,8" == label.QueryString || "8,1" == label.QueryString, "unexpected value '%s' (expected '1,8' or '8,1')", label.QueryString)
+	assert.Equal(t, true, label.QueryString == "1,8" || label.QueryString == "8,1", "unexpected value '%s' (expected '1,8' or '8,1')", label.QueryString)
 	assert.Equal(t, false, label.IsSelected)
 
 	// Third test : empty set