-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Open
Labels
type/refactoringExisting code has been cleaned up. There should be no new functionality.Existing code has been cleaned up. There should be no new functionality.
Description
this is currently not possible because we get a deadlock, at least on sqlite :/ (see comments and commits on #19576)
gitea/services/issue/status.go
Lines 22 to 23 in 92f139d
// changeStatusCtx changes issue status to open or closed. | |
// TODO: if context is not db.DefaultContext we get a deadlock!!! |
Lines 63 to 65 in 92f139d
// TODO: make it able to do this in a database session | |
mergeCtx := context.Background() | |
pr.MergedCommitID, err = rawMerge(mergeCtx, pr, doer, mergeStyle, expectedHeadCommitID, message) |
Lines 508 to 511 in 92f139d
// Push back to upstream. | |
// TODO: this cause an api call to "/api/internal/hook/post-receive/...", | |
// that prevents us from doint the whole merge in one db transaction | |
if err := pushCmd.Run(&git.RunOpts{ |
Metadata
Metadata
Assignees
Labels
type/refactoringExisting code has been cleaned up. There should be no new functionality.Existing code has been cleaned up. There should be no new functionality.