Commit list author rendering regression in v1.24+

[silverwind]

Description

In 1.24.2 and on main branch, I notice two bugs in the commit list author rendering. In the latest commit rendering, everything works as expected.

1. Author is not associated to local user via commit e-mail address despite e-mail address matching
2. The author link renders invalid hrefs which leads to the 404 page:

<a class="muted author-wrapper" href="/Firstname%20Lastname">Firstname Lastname</a>

Gitea Version

main

Can you reproduce the bug on the Gitea demo site?

no

How are you running Gitea?

natively

Database

MySQL/MariaDB

[silverwind]

To fix this, we should make commit list author rendering the same as for the latest commit. There is no reason these have different implementations.

[wxiaoguang]

Related to:

• Avatars not visible in commit view when no-reply address is configured to the real domain #34882
• Avatar not visisble in pr commit history rows #33595
• Improve commits list performance to reduce unnecessary database queries #33528
• Inconsistent commit signature color in Gitea v1.24 nightly #34641
• Fix GetUsersByEmails #34423
• Fix GetUsersByEmails (again) #34643

And please provide reproducible steps, and cc @lunny

[silverwind]

Issue 2 should reproduce for commits with any e-mail address that does not exist in gitea. Issue 1 is harder to reproduce, but I do see it in my local instance, so I can investigate there.

[wxiaoguang]

If a commit doesn't match existing Gitea user, then the commit's "git user" value will be filled into the link. It is not a regression, but an old behavior.

[silverwind]

But is it expected that this generates 404 links? In 1.23 and in last commit info, no link is generated for non-existant users.

[silverwind]

I think we should add a templates/repo/commit_author.tmpl to render the author (with or without link) and their avatar and use it everywhere.

[wxiaoguang]

But is it expected that this generates 404 links? In 1.23 and in last commit info, no link is generated for non-existant users.

Hmm, so it is a regression from

• Improve commits list performance to reduce unnecessary database queries #33528

[silverwind]

You can see an example of the invalid links generated here:

https://gitea.com/gitea/act/commits/branch/main

Commits with the gitea icon are external users, they should not render a link.

[silverwind]

Bug also affects commits in the pull request timeline (wrong avatar rendered, and the link over the avatar is the same broken 404 link).