gitea 1.9.0rc - missing binaries on tagged version

[Cherrg]

Shouldn't there be some build binaries and changelog on release list?

-> I don't know the whole workflow so I just asked.

drone build failed on tag-test https://drone.gitea.io/go-gitea/gitea/10493/1/11

[mrsdizzie]

It has not actually been released yet (per error above)

[lunny]

tag-test failed.

[Cherrg]

I tried to reproduce on local machine by make test. Are there some requirements to run those tests?
-> I got more and other error messages

[lunny]

It should not require others.

[techknowlogick]

This is the test that fails:

gitea/modules/git/repo_test.go

Line 15 in edc94c7

func TestGetLatestCommitTime(t *testing.T) {

It fails specifically by calling this function

gitea/modules/git/repo.go

Line 326 in edc94c7

func GetLatestCommitTime(repoPath string) (time.Time, error) {

which calls CLI git for-each-ref --sort=-committerdate refs/heads/ --count 1 --format=%(committerdate)

I've been able to replicate locally:

mkdir test
cd test
git init
git remote add origin https://github.com/go-gitea/gitea
git fetch origin +refs/tags/v1.9.0-rc1
git for-each-ref --sort=-committerdate refs/heads/ --count 1 --format=%\(committerdate\)

The last command returns `` which on a standard repo clone, or even a repo that has clone depth 200 it'll return a formatted date.

[lunny]

Yes, it needs a full clone I think but why it didn't fail before maybe because we changed .drone.yml to new format this release.

[techknowlogick]

It only failed with this tag because we introduced this test since release of 1.8 with merge of other git repo (now stored at modules/git). I don't think a full clone is needed, only something at refs/head so code will have something to reference.

[techknowlogick]

Ok. I have a solution that I've created a PR.