From 3b4f9f64dadab8434a00f13256a3fad4676d98c5 Mon Sep 17 00:00:00 2001 From: Kyle D Date: Tue, 22 Feb 2022 19:32:37 -0700 Subject: [PATCH 1/2] Set max text height to prevent overflow --- web_src/less/_review.less | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/web_src/less/_review.less b/web_src/less/_review.less index 1070ad7ddedcf..44535cf41285d 100644 --- a/web_src/less/_review.less +++ b/web_src/less/_review.less @@ -197,6 +197,10 @@ a.blob-excerpt:hover { color: #fff; } +#review-box .CodeMirror-scroll { + max-height: calc(100vh - 920px); +} + @media @mediaSm { #review-box > .menu { > .ui.segment { From a20c7c7e5b194563b008d0f0a7d4270097beb97c Mon Sep 17 00:00:00 2001 From: Kyle D Date: Tue, 22 Feb 2022 21:45:13 -0700 Subject: [PATCH 2/2] Move max height to EaseMDE init function --- web_src/js/features/repo-issue.js | 2 +- web_src/less/_review.less | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/web_src/js/features/repo-issue.js b/web_src/js/features/repo-issue.js index bdb75842f8552..4f791c7704a6b 100644 --- a/web_src/js/features/repo-issue.js +++ b/web_src/js/features/repo-issue.js @@ -462,7 +462,7 @@ export function initRepoPullRequestReview() { (async () => { // the editor's height is too large in some cases, and the panel cannot be scrolled with page now because there is `.repository .diff-detail-box.sticky { position: sticky; }` // the temporary solution is to make the editor's height smaller (about 4 lines). GitHub also only show 4 lines for default. We can improve the UI (including Dropzone area) in future - await createCommentEasyMDE($reviewBox.find('textarea'), {minHeight: '80px'}); + await createCommentEasyMDE($reviewBox.find('textarea'), {minHeight: '80px', maxHeight: 'calc(100vh - 360px)'}); initCompImagePaste($reviewBox); })(); } diff --git a/web_src/less/_review.less b/web_src/less/_review.less index 44535cf41285d..1070ad7ddedcf 100644 --- a/web_src/less/_review.less +++ b/web_src/less/_review.less @@ -197,10 +197,6 @@ a.blob-excerpt:hover { color: #fff; } -#review-box .CodeMirror-scroll { - max-height: calc(100vh - 920px); -} - @media @mediaSm { #review-box > .menu { > .ui.segment {