From 9bacd9026d4b52909e04a730b6d7c86d38c09718 Mon Sep 17 00:00:00 2001 From: Andrew Thornton Date: Thu, 18 Aug 2022 00:20:05 +0100 Subject: [PATCH] Check Mirror exists before linking its Repo In MirrorRepositoryList.loadAttributes there is some code to load the Mirror entries from the database. This assumes that every Repository which has IsMirror set has a Mirror associated in the DB. This association is incorrect in the case of Mirror repository under creation when there is no Mirror entry in the DB until completion. Unfortunately LoadAttributes makes this incorrect assumption and presumes that a Mirror will always be loaded. This then causes a panic. This PR simply double checks if there a Mirror before attempting to link back to its Repo. Unfortunately it should be expected that there may be other cases where this incorrect assumption causes further problems. Fix #20804 Signed-off-by: Andrew Thornton --- models/repo/mirror.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/models/repo/mirror.go b/models/repo/mirror.go index 8f96e8cee1851..e94bbda2c181d 100644 --- a/models/repo/mirror.go +++ b/models/repo/mirror.go @@ -153,7 +153,9 @@ func (repos MirrorRepositoryList) loadAttributes(ctx context.Context) error { } for i := range repos { repos[i].Mirror = set[repos[i].ID] - repos[i].Mirror.Repo = repos[i] + if repos[i].Mirror != nil { + repos[i].Mirror.Repo = repos[i] + } } return nil }