From 39991212cdee1f8a974dc0b0458565b15f3c9a9c Mon Sep 17 00:00:00 2001 From: silverwind Date: Sun, 9 Apr 2023 15:06:50 +0200 Subject: [PATCH 1/3] Introduce lint-md and compliance-docs pipeline --- .drone.yml | 65 ++++++++++++++++++++++++++++++++++++++++-------------- Makefile | 5 +++++ 2 files changed, 53 insertions(+), 17 deletions(-) diff --git a/.drone.yml b/.drone.yml index 225192c5d982b..c3daf671f8021 100644 --- a/.drone.yml +++ b/.drone.yml @@ -12,7 +12,8 @@ trigger: - pull_request paths: exclude: - - docs/** + - "docs/**" + - "*.md" volumes: - name: deps @@ -181,7 +182,7 @@ trigger: - pull_request paths: exclude: - - docs/** + - "docs/**" volumes: - name: deps @@ -266,6 +267,36 @@ steps: - name: deps path: /go +--- +kind: pipeline +type: docker +name: compliance-docs + +platform: + os: linux + arch: amd64 + +trigger: + event: + - pull_request + paths: + include: + - "docs/**" + - "*.md" + +steps: + - name: deps-frontend + image: node:18 + pull: always + commands: + - make deps-frontend + + - name: lint-md + image: node:18 + pull: always + commands: + - make lint-md + --- kind: pipeline type: docker @@ -283,7 +314,7 @@ trigger: - pull_request paths: exclude: - - docs/** + - "docs/**" volumes: - name: deps @@ -444,7 +475,7 @@ trigger: - pull_request paths: exclude: - - docs/** + - "docs/**" volumes: - name: deps @@ -530,7 +561,7 @@ trigger: - pull_request paths: exclude: - - docs/** + - "docs/**" volumes: - name: deps @@ -616,7 +647,7 @@ trigger: - pull_request paths: exclude: - - docs/** + - "docs/**" volumes: - name: deps @@ -696,7 +727,7 @@ trigger: - pull_request paths: exclude: - - docs/** + - "docs/**" volumes: - name: deps @@ -867,7 +898,7 @@ trigger: - push paths: exclude: - - docs/** + - "docs/**" depends_on: - testing-mysql @@ -1125,7 +1156,7 @@ trigger: - pull_request paths: include: - - docs/** + - "docs/**" steps: - name: build-docs @@ -1176,7 +1207,7 @@ trigger: - cron paths: exclude: - - docs/** + - "docs/**" steps: - name: fetch-tags @@ -1253,7 +1284,7 @@ trigger: - cron paths: exclude: - - docs/** + - "docs/**" steps: - name: fetch-tags @@ -1468,7 +1499,7 @@ trigger: - pull_request paths: exclude: - - docs/** + - "docs/**" steps: - name: dryrun @@ -1515,7 +1546,7 @@ trigger: - cron paths: exclude: - - docs/** + - "docs/**" steps: - name: fetch-tags @@ -1592,7 +1623,7 @@ trigger: - cron paths: exclude: - - docs/** + - "docs/**" steps: - name: fetch-tags @@ -1667,7 +1698,7 @@ trigger: - cron paths: exclude: - - docs/** + - "docs/**" steps: - name: fetch-tags @@ -1834,7 +1865,7 @@ trigger: - cron paths: exclude: - - docs/** + - "docs/**" depends_on: - docker-linux-amd64-release-version @@ -1884,7 +1915,7 @@ trigger: - cron paths: exclude: - - docs/** + - "docs/**" depends_on: - docker-linux-amd64-release diff --git a/Makefile b/Makefile index 56ac44eb11743..3b4d8a0e940ec 100644 --- a/Makefile +++ b/Makefile @@ -196,6 +196,7 @@ help: @echo " - lint lint everything" @echo " - lint-frontend lint frontend files" @echo " - lint-backend lint backend files" + @echo " - lint-md lint markdown files" @echo " - checks run various consistency checks" @echo " - checks-frontend check frontend files" @echo " - checks-backend check backend files" @@ -345,6 +346,10 @@ lint-frontend: node_modules npx eslint --color --max-warnings=0 --ext js,vue web_src/js build *.config.js docs/assets/js tests/e2e npx stylelint --color --max-warnings=0 web_src/css npx spectral lint -q -F hint $(SWAGGER_SPEC) + @$(MAKE) --no-print-directory lint-md + +.PHONY: lint-md +lint-md: node_modules npx markdownlint docs *.md .PHONY: lint-backend From 2eca468860dc9f7d71248531a76f2a1bfd387c6b Mon Sep 17 00:00:00 2001 From: silverwind Date: Sun, 9 Apr 2023 15:15:00 +0200 Subject: [PATCH 2/3] remove pull --- .drone.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.drone.yml b/.drone.yml index c3daf671f8021..5f1167d286b66 100644 --- a/.drone.yml +++ b/.drone.yml @@ -293,7 +293,6 @@ steps: - name: lint-md image: node:18 - pull: always commands: - make lint-md From 9bcfd308a56364986c920bef1c311cb1d8bcb2b1 Mon Sep 17 00:00:00 2001 From: silverwind Date: Sun, 9 Apr 2023 15:29:22 +0200 Subject: [PATCH 3/3] avoid sub-make --- Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 3b4d8a0e940ec..eb48766194f18 100644 --- a/Makefile +++ b/Makefile @@ -342,11 +342,10 @@ checks-backend: tidy-check swagger-check fmt-check misspell-check swagger-valida lint: lint-frontend lint-backend .PHONY: lint-frontend -lint-frontend: node_modules +lint-frontend: node_modules lint-md npx eslint --color --max-warnings=0 --ext js,vue web_src/js build *.config.js docs/assets/js tests/e2e npx stylelint --color --max-warnings=0 web_src/css npx spectral lint -q -F hint $(SWAGGER_SPEC) - @$(MAKE) --no-print-directory lint-md .PHONY: lint-md lint-md: node_modules