From 30dbf6196c2c5921123c0f108f69607977a6a194 Mon Sep 17 00:00:00 2001 From: zeripath Date: Wed, 10 May 2023 20:55:44 +0100 Subject: [PATCH 1/2] Skip redis test if redis-server not available If the `redis-server` command is not available then we should just skip the test. --- modules/queue/base_redis_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/queue/base_redis_test.go b/modules/queue/base_redis_test.go index 3d49e8d98c5fb..86b859f448cb0 100644 --- a/modules/queue/base_redis_test.go +++ b/modules/queue/base_redis_test.go @@ -56,7 +56,7 @@ func TestBaseRedis(t *testing.T) { }() if !waitRedisReady("redis://127.0.0.1:6379/0", 0) { redisServer = redisServerCmd(t) - if redisServer == nil && os.Getenv("CI") != "" { + if redisServer == nil || os.Getenv("CI") != "" { t.Skip("redis-server not found") return } From ce9b2a344838047d6c8f23989f4fec898778f032 Mon Sep 17 00:00:00 2001 From: zeripath Date: Wed, 10 May 2023 22:03:38 +0100 Subject: [PATCH 2/2] Update modules/queue/base_redis_test.go Co-authored-by: Kyle D. --- modules/queue/base_redis_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/queue/base_redis_test.go b/modules/queue/base_redis_test.go index 86b859f448cb0..19fbccbc8fe75 100644 --- a/modules/queue/base_redis_test.go +++ b/modules/queue/base_redis_test.go @@ -56,7 +56,7 @@ func TestBaseRedis(t *testing.T) { }() if !waitRedisReady("redis://127.0.0.1:6379/0", 0) { redisServer = redisServerCmd(t) - if redisServer == nil || os.Getenv("CI") != "" { + if redisServer == nil && os.Getenv("CI") == "" { t.Skip("redis-server not found") return }