From 6703a3fdc31e5564c9e21b3f919f247307287a71 Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Mon, 22 May 2023 21:53:33 +0200
Subject: [PATCH 1/5] Improve Actions CSS

---
 web_src/css/base.css                     |  4 +-
 web_src/css/themes/theme-arc-green.css   |  9 +++-
 web_src/js/components/RepoActionView.vue | 52 +++++++++++++++++-------
 3 files changed, 47 insertions(+), 18 deletions(-)

diff --git a/web_src/css/base.css b/web_src/css/base.css
index 04fc2a0f25a61..eee364bf1db65 100644
--- a/web_src/css/base.css
+++ b/web_src/css/base.css
@@ -70,8 +70,10 @@
   --color-secondary-alpha-90: #dededee1;
   /* console colors */
   --color-console-fg: #ffffff;
-  --color-console-bg: #171717;
+  --color-console-bg: #252a2f;
+  --color-console-border: #ffffff16;
   --color-console-hover-bg: #ffffff16;
+  --color-console-active-bg: #353a3f;
   /* named colors */
   --color-red: #db2828;
   --color-orange: #f2711c;
diff --git a/web_src/css/themes/theme-arc-green.css b/web_src/css/themes/theme-arc-green.css
index d5db18b55ae56..5f2b3294579c2 100644
--- a/web_src/css/themes/theme-arc-green.css
+++ b/web_src/css/themes/theme-arc-green.css
@@ -56,7 +56,13 @@
   --color-secondary-alpha-70: #525767b3;
   --color-secondary-alpha-80: #525767cc;
   --color-secondary-alpha-90: #525767e1;
-  /* colors */
+  /* console colors */
+  --color-console-fg: #ffffff;
+  --color-console-bg: #262936;
+  --color-console-border: #ffffff16;
+  --color-console-hover-bg: #ffffff16;
+  --color-console-active-bg: #383c47;
+  /* named colors */
   --color-red: #cc4848;
   --color-orange: #cc580c;
   --color-yellow: #cc9903;
@@ -175,7 +181,6 @@
   --color-accent: var(--color-primary-light-1);
   --color-small-accent: var(--color-primary-light-5);
   --color-active-line: #534d1b;
-
   accent-color: var(--color-accent);
   color-scheme: dark;
 }
diff --git a/web_src/js/components/RepoActionView.vue b/web_src/js/components/RepoActionView.vue
index b2fd63dd18e9e..241c2577059af 100644
--- a/web_src/js/components/RepoActionView.vue
+++ b/web_src/js/components/RepoActionView.vue
@@ -422,7 +422,6 @@ export function ansiLogToHTML(line) {
 <style scoped>
 .action-view-body {
   display: flex;
-  height: calc(100vh - 266px); /* fine tune this value to make the main view has full height */
 }
 
 /* ================ */
@@ -452,7 +451,11 @@ export function ansiLogToHTML(line) {
 .action-commit-summary {
   display: flex;
   gap: 5px;
-  margin: 10px 0px 10px 25px;
+  margin: 10px 0 0 25px;
+}
+
+.action-view-left, .action-view-right {
+  padding: 12px;
 }
 
 /* ================ */
@@ -461,7 +464,10 @@ export function ansiLogToHTML(line) {
 .action-view-left {
   width: 30%;
   max-width: 400px;
-  overflow-y: scroll;
+  position: sticky;
+  top: 0;
+  max-height: 100vh;
+  overflow-y: auto;
 }
 
 .job-group-section .job-group-summary {
@@ -490,11 +496,15 @@ export function ansiLogToHTML(line) {
   padding-right: 3px;
 }
 
+.job-brief-list {
+  display: flex;
+  flex-direction: column;
+  gap: 8px;
+}
+
 .job-brief-item {
-  margin: 5px 0;
   padding: 10px;
-  background: var(--color-info-bg);
-  border-radius: 5px;
+  border-radius: var(--border-radius);
   text-decoration: none;
   display: flex;
   flex-wrap: nowrap;
@@ -503,12 +513,12 @@ export function ansiLogToHTML(line) {
 }
 
 .job-brief-item:hover {
-  background-color: var(--color-secondary);
+  background-color: var(--color-hover);
 }
 
 .job-brief-item.selected {
   font-weight: var(--font-weight-bold);
-  background-color: var(--color-secondary-dark-1);
+  background-color: var(--color-active);
 }
 
 .job-brief-item:first-of-type {
@@ -555,8 +565,7 @@ export function ansiLogToHTML(line) {
 
 .action-view-right {
   flex: 1;
-  background-color: var(--color-console-bg);
-  color: var(--color-secondary-dark-2);
+  color: var(--color-secondary-dark-3);
   max-height: 100%;
   width: 70%;
   display: flex;
@@ -565,7 +574,12 @@ export function ansiLogToHTML(line) {
 
 .job-info-header {
   padding: 10px;
-  border-bottom: 1px solid var(--color-grey);
+  border-bottom: 1px solid var(--color-console-border);
+  background-color: var(--color-console-bg);
+  position: sticky;
+  top: 0;
+  border-radius: var(--border-radius) var(--border-radius) 0 0;
+  height: 60px;
 }
 
 .job-info-header .job-info-header-title {
@@ -580,8 +594,9 @@ export function ansiLogToHTML(line) {
 }
 
 .job-step-container {
+  background-color: var(--color-console-bg);
   max-height: 100%;
-  overflow: auto;
+  border-radius: 0 0 var(--border-radius) var(--border-radius);
 }
 
 .job-step-container .job-step-summary {
@@ -590,6 +605,7 @@ export function ansiLogToHTML(line) {
   display: flex;
   align-items: center;
   user-select: none;
+  border-radius: var(--border-radius);
 }
 
 .job-step-container .job-step-summary .step-summary-msg {
@@ -600,11 +616,17 @@ export function ansiLogToHTML(line) {
   margin-left: 16px;
 }
 
-.job-step-container .job-step-summary:hover,
+.job-step-container .job-step-summary:hover {
+  color: var(--color-console-fg);
+  background-color: var(--color-console-hover-bg);
+
+}
+
 .job-step-container .job-step-summary.selected {
   color: var(--color-console-fg);
-  background-color: var(--color-black-light);
-  border-radius: 5px;
+  background-color: var(--color-console-active-bg);
+  position: sticky;
+  top: 60px;
 }
 
 @media (max-width: 768px) {

From 5e6bd3b797556fcc9d75bd9722618cd9ad110dbb Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Mon, 22 May 2023 22:02:18 +0200
Subject: [PATCH 2/5] don't change fg on line hover

---
 web_src/js/components/RepoActionView.vue | 1 -
 1 file changed, 1 deletion(-)

diff --git a/web_src/js/components/RepoActionView.vue b/web_src/js/components/RepoActionView.vue
index 241c2577059af..375ec5410360c 100644
--- a/web_src/js/components/RepoActionView.vue
+++ b/web_src/js/components/RepoActionView.vue
@@ -671,7 +671,6 @@ export function ansiLogToHTML(line) {
 }
 
 .job-step-section .job-step-logs .job-log-line:hover {
-  color: var(--color-console-fg);
   background-color: var(--color-console-hover-bg);
 }
 

From 2b94760d99d7389e71f0ca78ac83f01af5127c9d Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Mon, 22 May 2023 23:32:27 +0200
Subject: [PATCH 3/5] use --fonts-monospace

---
 web_src/js/components/RepoActionView.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/web_src/js/components/RepoActionView.vue b/web_src/js/components/RepoActionView.vue
index 375ec5410360c..db323c475a9e7 100644
--- a/web_src/js/components/RepoActionView.vue
+++ b/web_src/js/components/RepoActionView.vue
@@ -661,7 +661,7 @@ export function ansiLogToHTML(line) {
 }
 
 .job-step-section .job-step-logs {
-  font-family: monospace, monospace;
+  font-family: var(--fonts-monospace);
   margin: 8px 0px;
   font-size: 12px;
 }

From dbe537aca884245188902fcbd9aab15ee988728d Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Tue, 23 May 2023 11:17:43 +0200
Subject: [PATCH 4/5] reduce margins

---
 web_src/js/components/RepoActionView.vue | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/web_src/js/components/RepoActionView.vue b/web_src/js/components/RepoActionView.vue
index db323c475a9e7..1d90372fec8a8 100644
--- a/web_src/js/components/RepoActionView.vue
+++ b/web_src/js/components/RepoActionView.vue
@@ -14,7 +14,7 @@
         <button class="ui basic small compact button red" @click="cancelRun()" v-else-if="run.canCancel">
           {{ locale.cancel }}
         </button>
-        <button class="ui basic small compact button secondary" @click="rerun()" v-else-if="run.canRerun">
+        <button class="ui basic small compact button secondary gt-mr-0" @click="rerun()" v-else-if="run.canRerun">
           {{ locale.rerun_all }}
         </button>
       </div>
@@ -422,19 +422,20 @@ export function ansiLogToHTML(line) {
 <style scoped>
 .action-view-body {
   display: flex;
+  gap: 12px;
 }
 
 /* ================ */
 /* action view header */
 
 .action-view-header {
-  margin: 20px 0px;
+  margin-top: 8px;
+  margin-bottom: 4px;
 }
 
 .action-info-summary {
   display: flex;
   align-items: center;
-  margin-top: 1rem;
   justify-content: space-between;
 }
 
@@ -451,11 +452,12 @@ export function ansiLogToHTML(line) {
 .action-commit-summary {
   display: flex;
   gap: 5px;
-  margin: 10px 0 0 25px;
+  margin: 5px 0 0 25px;
 }
 
 .action-view-left, .action-view-right {
-  padding: 12px;
+  padding-top: 12px;
+  padding-bottom: 12px;
 }
 
 /* ================ */

From de9650369cc0c44e6941aed4645d400ca58335b7 Mon Sep 17 00:00:00 2001
From: yp05327 <576951401@qq.com>
Date: Tue, 23 May 2023 06:26:48 +0900
Subject: [PATCH 5/5] Add validations.required check to dropdown field (#24849)

If dropdown is marked as required, we should not provide the `remove`
button.
This will cause user may post empty value which seems like a bug.

Definition:

![image](https://github.com/go-gitea/gitea/assets/18380374/cf48b478-244e-44e0-9a0e-7a0f02bc471a)
Post request form:

![image](https://github.com/go-gitea/gitea/assets/18380374/31d6f823-835f-422a-879c-3b1e18950ac8)
Result:

![image](https://github.com/go-gitea/gitea/assets/18380374/a9944fe9-24d0-4776-9eec-d31b70144eb4)
---
 templates/repo/issue/fields/dropdown.tmpl | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/templates/repo/issue/fields/dropdown.tmpl b/templates/repo/issue/fields/dropdown.tmpl
index 28e5d27e33aa9..23aa373cd2094 100644
--- a/templates/repo/issue/fields/dropdown.tmpl
+++ b/templates/repo/issue/fields/dropdown.tmpl
@@ -4,7 +4,9 @@
 	<div class="ui fluid selection dropdown {{if .item.Attributes.multiple}}multiple clearable{{end}}">
 		<input type="hidden" name="form-field-{{.item.ID}}" value="0">
 		{{svg "octicon-triangle-down" 14 "dropdown icon"}}
+		{{if not .item.Validations.required}}
 		{{svg "octicon-x" 14 "remove icon"}}
+		{{end}}
 		<div class="default text"></div>
 		<div class="menu">
 			{{range $i, $opt := .item.Attributes.options}}