From aba4f2aa1430c6f349d929362861fe0594403ca1 Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Tue, 7 Nov 2023 21:14:21 +0100 Subject: [PATCH 1/2] Document REACTION_MAX_USER_NUM setting option --- custom/conf/app.example.ini | 3 +++ docs/content/administration/config-cheat-sheet.en-us.md | 1 + 2 files changed, 4 insertions(+) diff --git a/custom/conf/app.example.ini b/custom/conf/app.example.ini index 2209822ff0869..bb5816285d0b1 100644 --- a/custom/conf/app.example.ini +++ b/custom/conf/app.example.ini @@ -1221,6 +1221,9 @@ LEVEL = Info ;; For custom reactions, add a tightly cropped square image to public/assets/img/emoji/reaction_name.png ;REACTIONS = +1, -1, laugh, hooray, confused, heart, rocket, eyes ;; +;; Change the users witch are displayed on mouse hover over (via tooltip) on reactions. +;REACTION_MAX_USER_NUM = 10 +;; ;; Additional Emojis not defined in the utf8 standard ;; By default we support gitea (:gitea:), to add more copy them to public/assets/img/emoji/emoji_name.png and add it to this config. ;; Dont mistake it for Reactions. diff --git a/docs/content/administration/config-cheat-sheet.en-us.md b/docs/content/administration/config-cheat-sheet.en-us.md index 715bd6d325f59..0562074ce6131 100644 --- a/docs/content/administration/config-cheat-sheet.en-us.md +++ b/docs/content/administration/config-cheat-sheet.en-us.md @@ -223,6 +223,7 @@ The following configuration set `Content-Type: application/vnd.android.package-a - `REACTIONS`: All available reactions users can choose on issues/prs and comments Values can be emoji alias (:smile:) or a unicode emoji. For custom reactions, add a tightly cropped square image to public/assets/img/emoji/reaction_name.png +- `REACTION_MAX_USER_NUM`: **10**: Change the users witch are displayed on mouse hover over (via tooltip) on reactions. - `CUSTOM_EMOJIS`: **gitea, codeberg, gitlab, git, github, gogs**: Additional Emojis not defined in the utf8 standard. By default, we support Gitea (:gitea:), to add more copy them to public/assets/img/emoji/emoji_name.png and add it to this config. From eb897a3823dd592b7d6dd01ea054a5c0641e1526 Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Tue, 7 Nov 2023 21:50:20 +0100 Subject: [PATCH 2/2] Apply suggestions from code review --- custom/conf/app.example.ini | 2 +- docs/content/administration/config-cheat-sheet.en-us.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/custom/conf/app.example.ini b/custom/conf/app.example.ini index bb5816285d0b1..a4e777fa12894 100644 --- a/custom/conf/app.example.ini +++ b/custom/conf/app.example.ini @@ -1221,7 +1221,7 @@ LEVEL = Info ;; For custom reactions, add a tightly cropped square image to public/assets/img/emoji/reaction_name.png ;REACTIONS = +1, -1, laugh, hooray, confused, heart, rocket, eyes ;; -;; Change the users witch are displayed on mouse hover over (via tooltip) on reactions. +;; Change the number of users that are displayed in reactions tooltip (triggered by mouse hover). ;REACTION_MAX_USER_NUM = 10 ;; ;; Additional Emojis not defined in the utf8 standard diff --git a/docs/content/administration/config-cheat-sheet.en-us.md b/docs/content/administration/config-cheat-sheet.en-us.md index 0562074ce6131..401da352c126f 100644 --- a/docs/content/administration/config-cheat-sheet.en-us.md +++ b/docs/content/administration/config-cheat-sheet.en-us.md @@ -223,7 +223,7 @@ The following configuration set `Content-Type: application/vnd.android.package-a - `REACTIONS`: All available reactions users can choose on issues/prs and comments Values can be emoji alias (:smile:) or a unicode emoji. For custom reactions, add a tightly cropped square image to public/assets/img/emoji/reaction_name.png -- `REACTION_MAX_USER_NUM`: **10**: Change the users witch are displayed on mouse hover over (via tooltip) on reactions. +- `REACTION_MAX_USER_NUM`: **10**: Change the number of users that are displayed in reactions tooltip (triggered by mouse hover). - `CUSTOM_EMOJIS`: **gitea, codeberg, gitlab, git, github, gogs**: Additional Emojis not defined in the utf8 standard. By default, we support Gitea (:gitea:), to add more copy them to public/assets/img/emoji/emoji_name.png and add it to this config.