From b681b7c9a23a9b3b310ead1420eee3646b71e87a Mon Sep 17 00:00:00 2001 From: lng2020 Date: Sun, 12 Nov 2023 00:02:59 +0800 Subject: [PATCH 1/2] fix wrong delete usage --- models/auth/source.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/models/auth/source.go b/models/auth/source.go index b3f3262cc206c..fcee1113a0de5 100644 --- a/models/auth/source.go +++ b/models/auth/source.go @@ -234,7 +234,7 @@ func CreateSource(ctx context.Context, source *Source) error { err = registerableSource.RegisterSource() if err != nil { // remove the AuthSource in case of errors while registering configuration - if _, err := db.GetEngine(ctx).Delete(source); err != nil { + if _, err := db.GetEngine(ctx).Delete(&Source{ID: source.ID}); err != nil { log.Error("CreateSource: Error while wrapOpenIDConnectInitializeError: %v", err) } } From 2a36ebea2ea2f366ce7501d186dee55b1f4d88b3 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Sun, 12 Nov 2023 13:19:13 +0800 Subject: [PATCH 2/2] Update models/auth/source.go Co-authored-by: delvh --- models/auth/source.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/models/auth/source.go b/models/auth/source.go index fcee1113a0de5..5f2781c808f2f 100644 --- a/models/auth/source.go +++ b/models/auth/source.go @@ -234,7 +234,7 @@ func CreateSource(ctx context.Context, source *Source) error { err = registerableSource.RegisterSource() if err != nil { // remove the AuthSource in case of errors while registering configuration - if _, err := db.GetEngine(ctx).Delete(&Source{ID: source.ID}); err != nil { + if _, err := db.GetEngine(ctx).ID(source.ID).Delete(new(Source)); err != nil { log.Error("CreateSource: Error while wrapOpenIDConnectInitializeError: %v", err) } }