From 4ebc20360122cf73da1c977da3451d9a13b40cb9 Mon Sep 17 00:00:00 2001 From: silverwind Date: Fri, 8 Mar 2024 17:52:08 +0100 Subject: [PATCH 1/2] Use more specific selector for `name` links --- web_src/js/markup/anchors.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/web_src/js/markup/anchors.js b/web_src/js/markup/anchors.js index 03934ea215fab..7b350d94e4a43 100644 --- a/web_src/js/markup/anchors.js +++ b/web_src/js/markup/anchors.js @@ -39,7 +39,8 @@ export function initMarkupAnchors() { if (!href.startsWith('#user-content-')) continue; const originalId = href.replace(/^#user-content-/, ''); a.setAttribute('href', `#${encodeURIComponent(originalId)}`); - if (document.getElementsByName(originalId).length !== 1) { + const nameLinks = a.closest('.markup').querySelectorAll(`a[name="${originalId}"]`); + if (nameLinks.length !== 1) { a.addEventListener('click', (e) => { scrollToAnchor(e.currentTarget.getAttribute('href'), false); }); From b2c61636f8efc2d6218df24549abe788b89813de Mon Sep 17 00:00:00 2001 From: silverwind Date: Fri, 8 Mar 2024 17:54:34 +0100 Subject: [PATCH 2/2] remove var --- web_src/js/markup/anchors.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/web_src/js/markup/anchors.js b/web_src/js/markup/anchors.js index 7b350d94e4a43..6cf83eb428b85 100644 --- a/web_src/js/markup/anchors.js +++ b/web_src/js/markup/anchors.js @@ -39,8 +39,7 @@ export function initMarkupAnchors() { if (!href.startsWith('#user-content-')) continue; const originalId = href.replace(/^#user-content-/, ''); a.setAttribute('href', `#${encodeURIComponent(originalId)}`); - const nameLinks = a.closest('.markup').querySelectorAll(`a[name="${originalId}"]`); - if (nameLinks.length !== 1) { + if (a.closest('.markup').querySelectorAll(`a[name="${originalId}"]`).length !== 1) { a.addEventListener('click', (e) => { scrollToAnchor(e.currentTarget.getAttribute('href'), false); });