Skip to content

Replace poetry with uv #35084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2025
Merged

Replace poetry with uv #35084

merged 2 commits into from
Jul 15, 2025

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jul 15, 2025 •
edited
Loading

Use the uv package manager to manage and run the two python dev dependencies.

I think flake.lock needs regeneration, but don't want to install nixos on my Mac. I wonder if there is a way to run nix flake lock standalone? maybe @techknowlogick can help.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 15, 2025
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jul 15, 2025
@techknowlogick
Copy link
Member

techknowlogick commented Jul 15, 2025 •
edited
Loading

@silverwind whoa, I just sent #35085 and I hadn't seen your message in this PR yet haha.

Edit: the good thing is that the lockfile doesn't target a version for each of the included packages in the flake, it is a version of the nixpkgs repository (so we target commit abc123, and that'd be the version of all our deps installed), regardless a bump to the flake is good.

@silverwind
Copy link
Member Author

silverwind commented Jul 15, 2025 •
edited
Loading

Ah okay so bascially flake.lock represents the host OS to run on, in a sense?

@techknowlogick
Copy link
Member

Ah okay so bascially flake.lock represents the host OS to run on, in a sense?

Not quite, it's "use the versions of packages from this snapshot of the nixpkgs repository" (there are some caveats but that's pretty close). So if nixpkgs has version 2 of packagae abc at a certain commit, and version 3 at another, the version that would be installed would be based on the commit version we target, and a nix flake update changes the commit we target (again, there are caveats, such as you can target multiple repos, but this is pretty close).

@silverwind
Copy link
Member Author

Ok, so the lockfile holds the version of all dependency packages. So if uv existed in nixpkgs before your PR, it's fine and will just be outdated to the date the lockfile was last written.

@techknowlogick
Copy link
Member

exactly

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 15, 2025
@techknowlogick techknowlogick enabled auto-merge (squash) July 15, 2025 20:52
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 15, 2025
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 15, 2025
@techknowlogick techknowlogick merged commit 7413e85 into go-gitea:main Jul 15, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone Jul 15, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 15, 2025
@silverwind silverwind deleted the uv branch July 15, 2025 21:32
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 16, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
e67766c 
* giteaofficial/main:
  Send email on Workflow Run Success/Failure (go-gitea#34982)
  [skip ci] Updated translations via Crowdin
  Replace `poetry` with `uv` (go-gitea#35084)
  nix flake update (go-gitea#35085)
  Use monospace font in PR command line instructions (go-gitea#35074)
  Add gitignore rules to exclude LLM instruction files (go-gitea#35076)
  [skip ci] Updated translations via Crowdin
  Fix form property assignment edge case (go-gitea#35073)
  Improve submodule relative path handling (go-gitea#35056)
  Fixed all grammatical errors in locale_en-US.ini (go-gitea#35053)
  UI: add hover background to table rows in user and repo admin page (go-gitea#35072)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/internal skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @techknowlogick @lunny @GiteaBot