From be90bc41f79bc5ab3b7160444a1ffdc61a1a2bc7 Mon Sep 17 00:00:00 2001 From: Rodrigo Villablanca Date: Fri, 20 Apr 2018 13:23:19 -0300 Subject: [PATCH 1/4] Fix to 3819 --- routers/user/home.go | 4 ++++ templates/user/dashboard/issues.tmpl | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/routers/user/home.go b/routers/user/home.go index 2a193bbdef519..844dbd9a87b1c 100644 --- a/routers/user/home.go +++ b/routers/user/home.go @@ -249,6 +249,10 @@ func Issues(ctx *context.Context) { opts.Page = page opts.PageSize = setting.UI.IssuePagingNum + + selectLabels := ctx.Query("labels") + opts.Labels = selectLabels + issues, err := models.Issues(opts) if err != nil { ctx.ServerError("Issues", err) diff --git a/templates/user/dashboard/issues.tmpl b/templates/user/dashboard/issues.tmpl index b41301b1080ec..1dcbb7aa33b74 100644 --- a/templates/user/dashboard/issues.tmpl +++ b/templates/user/dashboard/issues.tmpl @@ -71,7 +71,7 @@ especially on mobile views. */}} {{range .}} - {{.Name}} + {{.Name}} {{end}} {{end}} From c2ba0c16f84eba49c4a521c2508b2bb902e78b06 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rodrigo=20Villablanca=20V=C3=A1squez?= Date: Sun, 27 May 2018 16:39:00 -0400 Subject: [PATCH 2/4] Changes suggested --- routers/user/home.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/routers/user/home.go b/routers/user/home.go index 844dbd9a87b1c..cbf020978daff 100644 --- a/routers/user/home.go +++ b/routers/user/home.go @@ -249,10 +249,9 @@ func Issues(ctx *context.Context) { opts.Page = page opts.PageSize = setting.UI.IssuePagingNum - - selectLabels := ctx.Query("labels") - opts.Labels = selectLabels - + + opts.Labels := ctx.Query("labels") + issues, err := models.Issues(opts) if err != nil { ctx.ServerError("Issues", err) From 36f687cc061440cb201d59494be06333e0e9e3db Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rodrigo=20Villablanca=20V=C3=A1squez?= Date: Sun, 27 May 2018 16:41:24 -0400 Subject: [PATCH 3/4] Empty line removed --- routers/user/home.go | 1 - 1 file changed, 1 deletion(-) diff --git a/routers/user/home.go b/routers/user/home.go index cbf020978daff..1130fec309b6b 100644 --- a/routers/user/home.go +++ b/routers/user/home.go @@ -249,7 +249,6 @@ func Issues(ctx *context.Context) { opts.Page = page opts.PageSize = setting.UI.IssuePagingNum - opts.Labels := ctx.Query("labels") issues, err := models.Issues(opts) From 7243ed9b4e19aad4b2073ed11d8488434f603d53 Mon Sep 17 00:00:00 2001 From: Rodrigo Villablanca Date: Tue, 29 May 2018 14:34:44 -0400 Subject: [PATCH 4/4] Fix error: non-name opts.Labels on left side of := --- routers/user/home.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/routers/user/home.go b/routers/user/home.go index 1130fec309b6b..5ec7c80d618b2 100644 --- a/routers/user/home.go +++ b/routers/user/home.go @@ -249,8 +249,8 @@ func Issues(ctx *context.Context) { opts.Page = page opts.PageSize = setting.UI.IssuePagingNum - opts.Labels := ctx.Query("labels") - + opts.Labels = ctx.Query("labels") + issues, err := models.Issues(opts) if err != nil { ctx.ServerError("Issues", err)