Skip to content

fix: clear onerror #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2021
Merged

fix: clear onerror #207

merged 1 commit into from
Mar 16, 2021

Conversation

jpoehnelt
Copy link
Contributor

@jpoehnelt jpoehnelt commented Mar 16, 2021

The onerrorEvent wasn't being cleared internally. In some cases using the private interface in certain failure modes, this would prevent successful loading of the API.

closes #206

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 16, 2021
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #207 (da58c51) into master (6f428c6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #207   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          118       119    +1     
  Branches        24        24           
=========================================
+ Hits           118       119    +1     
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f428c6...da58c51. Read the comment docs.

@jpoehnelt jpoehnelt merged commit cf9206a into master Mar 16, 2021
@jpoehnelt jpoehnelt deleted the fix/onerror branch March 16, 2021 19:17
github-actions bot pushed a commit that referenced this pull request Mar 16, 2021
## [1.11.3](v1.11.2...v1.11.3) (2021-03-16)

### Bug Fixes

* clear onerror after exhausting retries ([#207](#207)) ([cf9206a](cf9206a))
@github-actions
Copy link

🎉 This PR is included in version 1.11.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load google maps api's Places after page becomes online
1 participant