Skip to content

fix(connection): Add customization options to connection resolver #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2020

Conversation

PeteMac88
Copy link
Contributor

@PeteMac88 PeteMac88 commented May 11, 2020

Draft PR closes #217

@PeteMac88 PeteMac88 marked this pull request as draft May 11, 2020 16:17

it('should return Resolver object with custom name', () => {
const resolver = connection(UserModel, UserTC, {
// $FlowFixMe
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not found a solution to fix this and the error thrown by flow also does not make sense to me. Any idea or fix appreciated,

@PeteMac88 PeteMac88 marked this pull request as ready for review May 12, 2020 17:00
@nodkz nodkz merged commit 8437357 into graphql-compose:master May 13, 2020
@nodkz
Copy link
Member

nodkz commented May 13, 2020

Thanks!

Don't worry about $FlowFixMe in tests. I the future I want to migrate all codebase on TypeScript. I'm very tired of Flow.

@nodkz
Copy link
Member

nodkz commented May 13, 2020

🎉 This PR is included in version 7.3.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nodkz nodkz added the released label May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend options for creation connection resolver
3 participants