Skip to content

{language/parser}: Updates test names for compatibility. #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025

Conversation

chris-ramon
Copy link
Member

Details

Test Plan

✔️ Tested via CI checks.

Copy link

mentatbot bot commented Jul 16, 2025

I'm getting to work. See my steps and track my cost here.

  • Wake on any new activity.
    I always see new activity while actively working. When paused, I'll only respond when tagged unless this box is checked. Learn more about triggers.

@coveralls
Copy link

Coverage Status

coverage: 92.048%. remained the same
when pulling e297ede on issue-724
into 58689e0 on master.

Copy link

mentatbot bot commented Jul 16, 2025

This PR looks good! The test name changes are consistent with the existing patterns in the codebase. I verified that:

✅ All 24 test functions have been properly renamed with the TestParser_ prefix
✅ Tests are passing (go test ./language/parser/ succeeds)
✅ This follows the established naming convention used by other packages in the language/ directory:

  • lexer_test.go uses TestLexer_ prefix
  • printer_test.go uses TestPrinter_ prefix
  • visitor_test.go uses TestVisitor_ prefix
  • schema_parser_test.go uses TestSchemaParser_ prefix

The changes are purely cosmetic and help maintain consistency across the codebase for compatibility with the GraphQL.js reference implementation.

Copy link
Member Author

@chris-ramon chris-ramon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🚢

@chris-ramon chris-ramon merged commit f2a7e55 into master Jul 18, 2025
6 checks passed
@chris-ramon chris-ramon deleted the issue-724 branch July 18, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

{parser}: Update test names.
2 participants