Skip to content

Fix bug when writing auto tidy config field tidy_cmpv2_nonce_store #29852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2025

Conversation

victorr
Copy link
Contributor

@victorr victorr commented Mar 6, 2025

Description

Fix a bug when writing auto tidy config field that prevents field tidy_cmpv2_nonce_store from being set.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@victorr victorr added this to the 1.19.1 milestone Mar 6, 2025
@victorr victorr self-assigned this Mar 6, 2025
@victorr victorr requested a review from a team as a code owner March 6, 2025 19:59
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 6, 2025
@victorr victorr force-pushed the victorr/vault-34539-auto-tidy-config-cmpv2 branch from 612d6da to d5c2fed Compare March 6, 2025 20:02
@victorr victorr requested a review from a team as a code owner March 6, 2025 20:02
@victorr victorr requested a review from paymanblu March 6, 2025 20:02
Copy link

github-actions bot commented Mar 6, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Mar 6, 2025

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@stevendpclark stevendpclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch PR looks good. While you are here, I believe there's another bug here that we don't set tidyCMPV2NonceStore in the tidyStatusStart function.

@victorr
Copy link
Contributor Author

victorr commented Mar 6, 2025

Thanks, pushed a changeset for tidyStatusStart.

@victorr victorr enabled auto-merge (squash) March 6, 2025 20:48
Copy link
Contributor

@stevendpclark stevendpclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@victorr victorr merged commit 735016d into main Mar 6, 2025
91 of 92 checks passed
@victorr victorr deleted the victorr/vault-34539-auto-tidy-config-cmpv2 branch March 6, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/ent/1.18.x+ent hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants