Update isInterface and resetInterfaceStore with @wz1000 feedback

Author: pepeiborra

ghcide/src/Development/IDE/Core/FileStore.hs

@@ -128,14 +128,13 @@ getModificationTimeRule vfs isWatched =
 --   But interface files are private, in that only HLS writes them.
 --   So we implement watching ourselves, and bypass the need for alwaysRerun.
 isInterface :: NormalizedFilePath -> Bool
-isInterface f = takeExtension (fromNormalizedFilePath f) `elem` [".hi", ".hie"]
+isInterface f = takeExtension (fromNormalizedFilePath f) `elem` [".hi", ".hi-boot"]
 
 -- | Reset the GetModificationTime state of interface files
-resetInterfaceStore :: ShakeExtras -> FilePath -> IO ()
+resetInterfaceStore :: ShakeExtras -> NormalizedFilePath -> IO ()
 resetInterfaceStore state f = do
-    forM_ [toNormalizedFilePath' (replaceExtension f ext) | ext <- ["hi","hie"]] $ \f ->
-        forM_ [True,False] $ \gmt ->
-            deleteValue state (GetModificationTime_ gmt) f
+    deleteValue state (GetModificationTime_ True) f
+    deleteValue state (GetModificationTime_ False) f
 
 -- | Reset the GetModificationTime state of watched files
 resetFileStore :: IdeState -> [FileEvent] -> IO ()

ghcide/src/Development/IDE/Core/Rules.hs

@@ -1095,7 +1095,7 @@ writeHiFileAction hsc hiFile = do
     extras <- getShakeExtras
     let targetPath = ml_hi_file $ ms_location $ hirModSummary hiFile
     liftIO $ do
-        resetInterfaceStore extras targetPath
+        resetInterfaceStore extras $ toNormalizedFilePath' targetPath
         writeHiFile hsc hiFile
 
 -- | A rule that wires per-file rules together