diff --git a/projects/components/src/navigation/navigation-list.component.test.ts b/projects/components/src/navigation/navigation-list.component.test.ts index ac60c0288..cb79ee4d0 100644 --- a/projects/components/src/navigation/navigation-list.component.test.ts +++ b/projects/components/src/navigation/navigation-list.component.test.ts @@ -1,6 +1,13 @@ import { ActivatedRoute } from '@angular/router'; import { IconType } from '@hypertrace/assets-library'; -import { FeatureState, FeatureStateResolver, MemoizeModule, NavigationService } from '@hypertrace/common'; +import { + ExternalNavigationWindowHandling, + FeatureState, + FeatureStateResolver, + MemoizeModule, + NavigationParamsType, + NavigationService +} from '@hypertrace/common'; import { createHostFactory, mockProvider, SpectatorHost } from '@ngneat/spectator/jest'; import { MockComponent } from 'ng-mocks'; import { EMPTY, of } from 'rxjs'; @@ -78,6 +85,11 @@ describe('Navigation List Component', () => { ); const footerItemsCount = spectator.component.footerItems?.length; expect(spectator.queryAll('.footer-item').length).toBe(footerItemsCount); + expect(spectator.query(LinkComponent)?.paramsOrUrl).toMatchObject({ + navType: NavigationParamsType.External, + url: 'http://test', + windowHandling: ExternalNavigationWindowHandling.NewWindow + }); }); test('should update layout when collapsed input is updated', () => { diff --git a/projects/components/src/navigation/navigation-list.component.ts b/projects/components/src/navigation/navigation-list.component.ts index acdc2f98c..8cdfd3c1c 100644 --- a/projects/components/src/navigation/navigation-list.component.ts +++ b/projects/components/src/navigation/navigation-list.component.ts @@ -1,7 +1,13 @@ import { ChangeDetectionStrategy, Component, EventEmitter, Input, OnChanges, Output } from '@angular/core'; import { ActivatedRoute } from '@angular/router'; import { IconType } from '@hypertrace/assets-library'; -import { NavigationService, TypedSimpleChanges } from '@hypertrace/common'; +import { + ExternalNavigationParams, + ExternalNavigationWindowHandling, + NavigationParamsType, + NavigationService, + TypedSimpleChanges +} from '@hypertrace/common'; import { Observable } from 'rxjs'; import { map, startWith } from 'rxjs/operators'; import { IconSize } from '../icon/icon-size'; @@ -70,7 +76,7 @@ import {