[Driver] Apply review comments

Signed-off-by: Victor Lomuller <[email protected]>

Author: Naghasan

clang/include/clang/Driver/Action.h

@@ -876,8 +876,8 @@ class StaticLibJobAction : public JobAction {
 ///   - No change of toolchain, boundarch and offloading kind should occur
 ///     within the sub-region;
 ///   - No job should produce multiple outputs;
-///   - Results of action within the sub-region should not be used the wrapped
-///     region.
+///   - Results of action within the sub-region should not be used ouside the
+///     wrapped region.
 /// Note: this doesn't bind to a tool directly and this need special casing
 /// anyhow. Hence why this is an Action and not a JobAction, even if there is a
 /// command behind.

clang/include/clang/Driver/Job.h

@@ -319,7 +319,8 @@ class JobList {
   /// Clear the job list.
   void clear();
 
-  list_type &getJobs() { return Jobs; }
+  /// Return a mutable list of Jobs for llvm-foreach wrapping.
+  list_type &getJobsForOverride() { return Jobs; }
   const list_type &getJobs() const { return Jobs; }
 
   bool empty() const { return Jobs.empty(); }

clang/lib/Driver/Driver.cpp

@@ -6369,13 +6369,13 @@ InputInfo Driver::BuildJobsForActionNoCache(
                        /*AtTopLevel=*/false, MultipleArchs, LinkingOutput,
                        CachedResults, TargetDeviceOffloadKind);
 
-    auto begin = C.getJobs().getJobs().begin() + OffsetIdx;
-    auto end = C.getJobs().getJobs().end();
+    auto begin = C.getJobs().getJobsForOverride().begin() + OffsetIdx;
+    auto end = C.getJobs().getJobsForOverride().end();
 
     // Steal the commands.
     llvm::SmallVector<std::unique_ptr<Command>, 4> JobsToWrap(
         std::make_move_iterator(begin), std::make_move_iterator(end));
-    C.getJobs().getJobs().erase(begin, end);
+    C.getJobs().getJobsForOverride().erase(begin, end);
 
     InputInfo ActionResult;
     for (std::unique_ptr<Command> Cmd :