Skip to content

Commit 2f36f11

Browse files
authored
[Benchmarks] Remove stdout field from results (#19282)
This field is not used anywhere in scripts nor in the dashboard. It was merely saved in the results objects in run json files and copied into data.json making the file significantly bigger.
1 parent c270247 commit 2f36f11

File tree

9 files changed

+2
-12
lines changed

9 files changed

+2
-12
lines changed

devops/scripts/benchmarks/benches/benchdnn.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,6 @@ def run(self, env_vars):
161161
unit="ms",
162162
command=command,
163163
env=env_vars,
164-
stdout=output,
165164
git_url=self.suite.git_url(),
166165
git_hash=self.suite.git_tag(),
167166
)

devops/scripts/benchmarks/benches/compute.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,6 @@ def run(self, env_vars) -> list[Result]:
303303
stddev=stddev,
304304
command=command,
305305
env=env_vars,
306-
stdout=result,
307306
unit=parse_unit_type(unit),
308307
git_url=self.bench.git_url(),
309308
git_hash=self.bench.git_hash(),

devops/scripts/benchmarks/benches/gromacs.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515

1616

1717
class GromacsBench(Suite):
18-
1918
def git_url(self):
2019
return "https://gitlab.com/gromacs/gromacs.git"
2120

@@ -221,7 +220,6 @@ def run(self, env_vars):
221220
unit="s",
222221
command=command,
223222
env=env_vars,
224-
stdout=mdrun_output,
225223
git_url=self.suite.git_url(),
226224
git_hash=self.suite.git_tag(),
227225
)

devops/scripts/benchmarks/benches/llamacpp.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,6 @@ def run(self, env_vars) -> list[Result]:
154154
value=mean,
155155
command=command,
156156
env=env_vars,
157-
stdout=result,
158157
unit="token/s",
159158
git_url=self.bench.git_url(),
160159
git_hash=self.bench.git_hash(),

devops/scripts/benchmarks/benches/syclbench.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,6 @@ def run(self, env_vars) -> list[Result]:
165165
passed=(row[1] == "PASS"),
166166
command=command,
167167
env=env_vars,
168-
stdout=row,
169168
unit="ms",
170169
git_url=self.bench.git_url(),
171170
git_hash=self.bench.git_hash(),

devops/scripts/benchmarks/benches/test.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ def run(self, env_vars) -> list[Result]:
9696
value=random_value,
9797
command=["test", "--arg1", "foo"],
9898
env={"A": "B"},
99-
stdout="no output",
10099
unit="ms",
101100
)
102101
]

devops/scripts/benchmarks/benches/umf.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,6 @@ def run(self, env_vars) -> list[Result]:
165165
value=value,
166166
command=command,
167167
env=env_vars,
168-
stdout=result,
169168
unit=self.get_unit_time_or_overhead(explicit_group),
170169
)
171170
)

devops/scripts/benchmarks/benches/velocity.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,6 @@ def run(self, env_vars) -> list[Result]:
146146
value=self.parse_output(result),
147147
command=command,
148148
env=env_vars,
149-
stdout=result,
150149
unit=self.unit,
151150
git_url=self.vb.git_url(),
152151
git_hash=self.vb.git_hash(),

devops/scripts/benchmarks/utils/result.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ class Result:
1515
value: float
1616
command: list[str]
1717
env: dict[str, str]
18-
stdout: str
1918
passed: bool = True
2019
unit: str = ""
2120
# stddev can be optionally set by the benchmark,
@@ -36,8 +35,8 @@ class BenchmarkRun:
3635
name: str = "This PR"
3736
hostname: str = "Unknown"
3837
git_hash: str = ""
39-
github_repo: str = None
40-
date: datetime = field(
38+
github_repo: str = ""
39+
date: datetime | None = field(
4140
default=None,
4241
metadata=config(encoder=datetime.isoformat, decoder=datetime.fromisoformat),
4342
)

0 commit comments

Comments
 (0)