[SYCL] Improve code-ownership rules for ESIMD/Tools (#5287)

The patch aims to enforce ESIMD-specific code-ownership on the newly created
dedicated directories. This allows for seamless DPC++ Tools code-ownership of
non-ESIMD `llvm/`-contained files.

Signed-off-by: Artem Gindinson <[email protected]>

Author: Artem Gindinson

.github/CODEOWNERS

@@ -48,7 +48,7 @@ llvm/ @intel/dpcpp-tools-reviewers
 clang/tools/clang-offload-*/ @intel/dpcpp-tools-reviewers
 
 # Explicit SIMD
-SYCLLowerIR/ @intel/dpcpp-esimd-reviewers
+ESIMD/ @intel/dpcpp-esimd-reviewers
 esimd/ @intel/dpcpp-esimd-reviewers
 sycl/include/sycl/ext/intel/experimental/esimd.hpp @intel/dpcpp-esimd-reviewers
 sycl/doc/extensions/ExplicitSIMD/ @intel/dpcpp-esimd-reviewers

clang/lib/CodeGen/BackendUtil.cpp

@@ -42,7 +42,7 @@
 #include "llvm/Passes/PassBuilder.h"
 #include "llvm/Passes/PassPlugin.h"
 #include "llvm/Passes/StandardInstrumentations.h"
-#include "llvm/SYCLLowerIR/ESIMDVerifier.h"
+#include "llvm/SYCLLowerIR/ESIMD/ESIMDVerifier.h"
 #include "llvm/SYCLLowerIR/LowerWGLocalMemory.h"
 #include "llvm/SYCLLowerIR/MutatePrintfAddrspace.h"
 #include "llvm/Support/BuryPointer.h"

llvm/include/llvm/LinkAllPasses.h

@@ -37,7 +37,7 @@
 #include "llvm/CodeGen/Passes.h"
 #include "llvm/IR/Function.h"
 #include "llvm/IR/IRPrintingPasses.h"
-#include "llvm/SYCLLowerIR/ESIMDVerifier.h"
+#include "llvm/SYCLLowerIR/ESIMD/ESIMDVerifier.h"
 #include "llvm/SYCLLowerIR/MutatePrintfAddrspace.h"
 #include "llvm/Support/Valgrind.h"
 #include "llvm/Transforms/AggressiveInstCombine/AggressiveInstCombine.h"

llvm/include/llvm/SYCLLowerIR/ESIMDVerifier.h renamed to llvm/include/llvm/SYCLLowerIR/ESIMD/ESIMDVerifier.h

@@ -76,8 +76,8 @@
 #include "llvm/IR/PrintPasses.h"
 #include "llvm/IR/SafepointIRVerifier.h"
 #include "llvm/IR/Verifier.h"
-#include "llvm/SYCLLowerIR/ESIMDVerifier.h"
-#include "llvm/SYCLLowerIR/LowerESIMD.h"
+#include "llvm/SYCLLowerIR/ESIMD/ESIMDVerifier.h"
+#include "llvm/SYCLLowerIR/ESIMD/LowerESIMD.h"
 #include "llvm/SYCLLowerIR/LowerWGScope.h"
 #include "llvm/SYCLLowerIR/MutatePrintfAddrspace.h"
 #include "llvm/Support/CommandLine.h"

llvm/include/llvm/SYCLLowerIR/LowerESIMD.h renamed to llvm/include/llvm/SYCLLowerIR/ESIMD/LowerESIMD.h

@@ -48,12 +48,12 @@ set_property(GLOBAL PROPERTY LLVMGenXIntrinsics_SOURCE_PROP ${LLVMGenXIntrinsics
 set_property(GLOBAL PROPERTY LLVMGenXIntrinsics_BINARY_PROP ${LLVMGenXIntrinsics_BINARY_DIR})
 
 add_llvm_component_library(LLVMSYCLLowerIR
+  ESIMD/LowerESIMD.cpp
+  ESIMD/LowerESIMDVLoadVStore.cpp
+  ESIMD/LowerESIMDVecArg.cpp
+  ESIMD/ESIMDVerifier.cpp
   LowerWGScope.cpp
-  LowerESIMD.cpp
-  LowerESIMDVLoadVStore.cpp
-  LowerESIMDVecArg.cpp
   LowerWGLocalMemory.cpp
-  ESIMDVerifier.cpp
   MutatePrintfAddrspace.cpp
 
   ADDITIONAL_HEADER_DIRS

llvm/lib/Passes/PassBuilder.cpp

@@ -11,7 +11,7 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include "llvm/SYCLLowerIR/ESIMDVerifier.h"
+#include "llvm/SYCLLowerIR/ESIMD/ESIMDVerifier.h"
 #include "llvm/Demangle/Demangle.h"
 #include "llvm/IR/InstIterator.h"
 #include "llvm/IR/Instructions.h"

llvm/lib/SYCLLowerIR/CMakeLists.txt

@@ -13,7 +13,7 @@
 // values of integer template parameters they were instantiated with.
 //===----------------------------------------------------------------------===//
 
-#include "llvm/SYCLLowerIR/LowerESIMD.h"
+#include "llvm/SYCLLowerIR/ESIMD/LowerESIMD.h"
 
 #include "llvm/ADT/DenseMap.h"
 #include "llvm/ADT/DenseSet.h"
@@ -126,8 +126,8 @@ struct ESIMDIntrinDesc {
                                 // -1 denotes return value
         GenXArgConversion Conv; // GenXArgConversion
       } Arg;
-      int NRemArgs;           // SRC_CALL_ALL: number of remaining args
-      unsigned int ArgConst;  // CONST_I16 OR CONST_I32: constant value
+      int NRemArgs;          // SRC_CALL_ALL: number of remaining args
+      unsigned int ArgConst; // CONST_I16 OR CONST_I32: constant value
     } I;
   };
 
@@ -546,7 +546,7 @@ class SimpleAllocator {
     Ptrs.resize(0);
   }
 
-  template <typename T, typename... Args> T *makeNode(Args &&... args) {
+  template <typename T, typename... Args> T *makeNode(Args &&...args) {
     void *Ptr = std::calloc(1, sizeof(T));
     Ptrs.push_back(Ptr);
     return new (Ptr) T(std::forward<Args>(args)...);

llvm/lib/SYCLLowerIR/ESIMDVerifier.cpp renamed to llvm/lib/SYCLLowerIR/ESIMD/ESIMDVerifier.cpp

@@ -28,7 +28,7 @@
 #include "llvm/IR/Instructions.h"
 #include "llvm/IR/IntrinsicInst.h"
 #include "llvm/IR/Module.h"
-#include "llvm/SYCLLowerIR/LowerESIMD.h"
+#include "llvm/SYCLLowerIR/ESIMD/LowerESIMD.h"
 #include "llvm/Support/Debug.h"
 #include "llvm/Transforms/Scalar.h"