Skip to content

Commit f4ab328

Browse files
committed
Apply CR comments
Signed-off-by: Mariya Podchishchaeva <[email protected]>
1 parent 8568786 commit f4ab328

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

clang/lib/Sema/SemaSYCL.cpp

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -644,18 +644,19 @@ static target getAccessTarget(const ClassTemplateSpecializationDecl *AccTy) {
644644
AccTy->getTemplateArgs()[3].getAsIntegral().getExtValue());
645645
}
646646

647-
// The first template argument to the kernel function is used to identify the
648-
// kernel itself.
647+
// The first template argument to the kernel caller function is used to identify
648+
// the kernel itself.
649649
static QualType calculateKernelNameType(ASTContext &Ctx,
650650
FunctionDecl *KernelCallerFunc) {
651651
const TemplateArgumentList *TAL =
652652
KernelCallerFunc->getTemplateSpecializationArgs();
653+
assert(TAL && "No template argument info");
653654
return TypeName::getFullyQualifiedType(TAL->get(0).getAsType(), Ctx,
654655
/*WithGlobalNSPrefix=*/true);
655656
}
656657

657-
// Gets a name for the kernel caller func, calculated from the first template
658-
// argument.
658+
// Gets a name for the OpenCL kernel function, calculated from the first
659+
// template argument of the kernel caller function.
659660
static std::pair<std::string, std::string>
660661
constructKernelName(Sema &S, FunctionDecl *KernelCallerFunc, MangleContext &MC) {
661662
QualType KernelNameType =
@@ -996,7 +997,7 @@ class SyclKernelDeclCreator
996997
}
997998

998999
void handleSyclStreamType(const CXXBaseSpecifier &, QualType FieldTy) final {
999-
// FIXME SYCL stream should be usable usable as a base type
1000+
// FIXME SYCL stream should be usable as a base type
10001001
// See https://github.com/intel/llvm/issues/1552
10011002
}
10021003

@@ -1212,7 +1213,7 @@ class SyclKernelBodyCreator
12121213
}
12131214

12141215
void handleSyclAccessorType(const CXXBaseSpecifier &BS, QualType Ty) final {
1215-
// FIXME SYCL accessor should be usable usable as a base type
1216+
// FIXME SYCL accessor should be usable as a base type
12161217
// See https://github.com/intel/llvm/issues/28.
12171218
}
12181219

@@ -1230,7 +1231,7 @@ class SyclKernelBodyCreator
12301231
}
12311232

12321233
void handleSyclStreamType(const CXXBaseSpecifier &BS, QualType Ty) final {
1233-
// FIXME SYCL stream should be usable usable as a base type
1234+
// FIXME SYCL stream should be usable as a base type
12341235
// See https://github.com/intel/llvm/issues/1552
12351236
}
12361237

@@ -1365,7 +1366,7 @@ class SyclKernelIntHeaderCreator
13651366
}
13661367
void handleSyclStreamType(const CXXBaseSpecifier &BC,
13671368
QualType FieldTy) final {
1368-
// FIXME SYCL stream should be usable usable as a base type
1369+
// FIXME SYCL stream should be usable as a base type
13691370
// See https://github.com/intel/llvm/issues/1552
13701371
}
13711372

0 commit comments

Comments
 (0)