[SYCL][ESIMD] Add support for local accessors to lsc API #10340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turinevgeny
reviewed
Jul 19, 2023
turinevgeny
reviewed
Jul 20, 2023
sycl/test-e2e/ESIMD/lsc/lsc_local_accessor_block_load_store.cpp
Outdated
Show resolved
Hide resolved
turinevgeny
reviewed
Jul 20, 2023
turinevgeny
reviewed
Jul 25, 2023
turinevgeny
approved these changes
Jul 25, 2023
v-klochkov
reviewed
Jul 28, 2023
| !std::is_same_v<Toffset, uint64_t>, | ||
| __ESIMD_NS::simd<T, N * NElts>> | ||
| __ESIMD_API std::enable_if_t< | ||
| !std::is_pointer_v<AccessorTy> && |
There was a problem hiding this comment.
Just a note here:
!std::is_pointer_v is a bad check (not because of your PR). It allows using write-only accessors lsc_gather() operations. Same/vice-versa is for read-only accessors usable in write operations in other places in memory.hpp here.
I created internal tracker for this issue.
There was a problem hiding this comment.
The much better check is used for copy_to() and copy_from(), e.g. copy_from():
detail::is_sycl_accessor_with<
AccessorT, accessor_mode_cap::can_read,
sycl::access::target::device>::value)
v-klochkov
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.