[SYCL] Update kernel function metadata after local accessor pass #10727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @jinz2014 |
|
This was discovered by: #9772 |
jchlanda
force-pushed
the
jakub/metadata_preserve
branch
2 times, most recently
from
65b7495 to
63ca278
Compare
|
I'm not having much luck with CI on this PR, but the failures don't seem to be related @intel/llvm-gatekeepers |
hdelan
reviewed
Aug 16, 2023
llvm/test/CodeGen/NVPTX/local-accessor-to-shared-memory-basic-transformation.ll
Outdated
Show resolved
Hide resolved
jchlanda
force-pushed
the
jakub/metadata_preserve
branch
from
8e5f3bd to
7870ea3
Compare
AlexeySachkov
approved these changes
Aug 16, 2023
|
Not sure if you've seen this @zjin-lcf |
|
@intel/llvm-gatekeepers the errors seem to be unrelated. |
Sorry, I didn't reply to your pings earlier. I appreciate your PR, which will enable the support of "minBlocksPerMultiprocessor" and "maxThreadsPerBlock". |
@jchlanda due to the CI failures that happened, no gen12 tests at all were run. So we can not merge these in with these results. I have restarted your test results and if all is clean, than the gatekeepers will merge in. |
Co-authored-by: Alexey Sachkov <[email protected]>
Co-authored-by: Alexey Sachkov <[email protected]>
Co-authored-by: Alexey Sachkov <[email protected]>
jchlanda
force-pushed
the
jakub/metadata_preserve
branch
from
6549314 to
b60673d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that metadata containing the kernel function is correctly updated after local accessor to shared memory pass is run.