[SYCL][Graph] Fix memset queue shortcut when queue is recorded #12508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memset queue shortcut `queue::memset()` manages the memset direclty from the host (without going through the normal path, i.e. the handler). We added a specific case when the queue is recorded to use the normal path instead of the optimized path.
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mfrancepillois
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
mfrancepillois
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mfrancepillois
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mfrancepillois
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mfrancepillois
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mfrancepillois
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
#11758 is going in in a moment. I think we can benefit by waiting and rebasing once that happens. Also, + @sergey-semenov who's the expert in the area. |
| // RUN: %{build} -o %t.out | ||
| // RUN: %{run} %t.out | ||
| // Extra run to check for leaks in Level Zero using ZE_DEBUG | ||
| // RUN: %if ext_oneapi_level_zero %{env ZE_DEBUG=4 %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %} |
There was a problem hiding this comment.
Hasn't that been changed to UR_L0_LEAKS_DEBUG?
There was a problem hiding this comment.
You're right. This test has been updated.
reble
reviewed
Jan 26, 2024
sycl/source/detail/queue_impl.cpp
Outdated
| "The memset feature is not yet available " | ||
| "for use with the SYCL Graph extension."); | ||
| return submit( | ||
| [&](handler &CGH) { |
There was a problem hiding this comment.
Not sure if it really makes a difference: but shouldn't we capture (parameters other than DepEvents) by value here instead?
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Bensuo
reviewed
Feb 8, 2024
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
approved these changes
Feb 8, 2024
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Bensuo
approved these changes
Feb 12, 2024
|
@intel/llvm-gatekeepers could you please merge this PR? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memset queue shortcut
queue::memset()manages the memset direclty from the host (without going through the normal path, i.e. the handler).We added a specific case when the queue is recorded to use the normal path instead of the optimized path.