From a256b6e22284a61d5748056fb90e57b0d2574d36 Mon Sep 17 00:00:00 2001 From: Sergey Semenov Date: Mon, 29 Jan 2024 09:00:19 -0800 Subject: [PATCH 1/3] [SYCL] Fix unused variable warning --- sycl/source/detail/queue_impl.cpp | 2 +- sycl/source/detail/queue_impl.hpp | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/sycl/source/detail/queue_impl.cpp b/sycl/source/detail/queue_impl.cpp index 6fdfdd7a4d11c..cdfe2dbb8c1af 100644 --- a/sycl/source/detail/queue_impl.cpp +++ b/sycl/source/detail/queue_impl.cpp @@ -322,7 +322,7 @@ areEventsSafeForSchedulerBypass(const std::vector &DepEvents, }; return std::all_of(DepEvents.begin(), DepEvents.end(), - [&Context, &CheckEvent](const sycl::event &Event) { + [&CheckEvent](const sycl::event &Event) { return CheckEvent(Event); }); } diff --git a/sycl/source/detail/queue_impl.hpp b/sycl/source/detail/queue_impl.hpp index 722acf925cf8d..810f991d6667f 100644 --- a/sycl/source/detail/queue_impl.hpp +++ b/sycl/source/detail/queue_impl.hpp @@ -744,8 +744,7 @@ class queue_impl { // template is needed for proper unit testing template - void finalizeHandler(HandlerType &Handler, const CG::CGTYPE &Type, - event &EventRet) { + void finalizeHandler(HandlerType &Handler, event &EventRet) { if (MIsInorder) { // Accessing and changing of an event isn't atomic operation. // Hence, here is the lock for thread-safety. @@ -831,11 +830,11 @@ class queue_impl { !(Handler.MKernel && Handler.MKernel->isInterop()) && ProgramManager::getInstance().kernelUsesAssert(Handler.MKernelName); - finalizeHandler(Handler, Type, Event); + finalizeHandler(Handler, Event); (*PostProcess)(IsKernel, KernelUsesAssert, Event); } else - finalizeHandler(Handler, Type, Event); + finalizeHandler(Handler, Event); addEvent(Event); return Event; From 0f6996f7bbf2238ec8e143fa5350cb96f3690473 Mon Sep 17 00:00:00 2001 From: Sergey Semenov Date: Mon, 29 Jan 2024 09:36:53 -0800 Subject: [PATCH 2/3] Appease clang-format --- sycl/source/detail/queue_impl.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sycl/source/detail/queue_impl.cpp b/sycl/source/detail/queue_impl.cpp index cdfe2dbb8c1af..545cff3b9c5c3 100644 --- a/sycl/source/detail/queue_impl.cpp +++ b/sycl/source/detail/queue_impl.cpp @@ -321,10 +321,9 @@ areEventsSafeForSchedulerBypass(const std::vector &DepEvents, return SyclEventImplPtr->getHandleRef() != nullptr; }; - return std::all_of(DepEvents.begin(), DepEvents.end(), - [&CheckEvent](const sycl::event &Event) { - return CheckEvent(Event); - }); + return std::all_of( + DepEvents.begin(), DepEvents.end(), + [&CheckEvent](const sycl::event &Event) { return CheckEvent(Event); }); } template From 7fac2a24d5ea773acdb8d7f07e043ca6aba64b57 Mon Sep 17 00:00:00 2001 From: Sergey Semenov Date: Mon, 29 Jan 2024 10:09:49 -0800 Subject: [PATCH 3/3] Align unit test --- .../unittests/scheduler/InOrderQueueSyncCheck.cpp | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/sycl/unittests/scheduler/InOrderQueueSyncCheck.cpp b/sycl/unittests/scheduler/InOrderQueueSyncCheck.cpp index 4b50791981258..f88dea4b398f9 100644 --- a/sycl/unittests/scheduler/InOrderQueueSyncCheck.cpp +++ b/sycl/unittests/scheduler/InOrderQueueSyncCheck.cpp @@ -72,35 +72,30 @@ TEST_F(SchedulerTest, InOrderQueueSyncCheck) { { LimitedHandlerSimulation MockCGH; EXPECT_CALL(MockCGH, depends_on).Times(0); - Queue->finalizeHandler( - MockCGH, detail::CG::CGTYPE::CodeplayHostTask, Event); + Queue->finalizeHandler(MockCGH, Event); } // host task { LimitedHandlerSimulation MockCGH; EXPECT_CALL(MockCGH, depends_on).Times(1); - Queue->finalizeHandler( - MockCGH, detail::CG::CGTYPE::CodeplayHostTask, Event); + Queue->finalizeHandler(MockCGH, Event); } // kernel task { LimitedHandlerSimulation MockCGH; EXPECT_CALL(MockCGH, depends_on).Times(1); - Queue->finalizeHandler( - MockCGH, detail::CG::CGTYPE::Kernel, Event); + Queue->finalizeHandler(MockCGH, Event); } // kernel task { LimitedHandlerSimulation MockCGH; EXPECT_CALL(MockCGH, depends_on).Times(1); - Queue->finalizeHandler( - MockCGH, detail::CG::CGTYPE::Kernel, Event); + Queue->finalizeHandler(MockCGH, Event); } // host task { LimitedHandlerSimulation MockCGH; EXPECT_CALL(MockCGH, depends_on).Times(1); - Queue->finalizeHandler( - MockCGH, detail::CG::CGTYPE::CodeplayHostTask, Event); + Queue->finalizeHandler(MockCGH, Event); } }