Skip to content

[SYCL] Fix CTAD related warnings #12539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2024
Merged

[SYCL] Fix CTAD related warnings #12539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions sycl/unittests/scheduler/InOrderQueueHostTaskDeps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ TEST_F(SchedulerTest, InOrderQueueCrossDeps) {

InOrderQueue.submit([&](sycl::handler &CGH) {
CGH.host_task([&] {
std::unique_lock lk(CvMutex);
std::unique_lock<std::mutex> lk(CvMutex);
Cv.wait(lk, [&ready] { return ready; });
});
});
Expand All @@ -107,7 +107,7 @@ TEST_F(SchedulerTest, InOrderQueueCrossDeps) {
});

{
std::unique_lock lk(CvMutex);
std::unique_lock<std::mutex> lk(CvMutex);
ready = true;
}
Cv.notify_one();
Expand Down Expand Up @@ -144,7 +144,7 @@ TEST_F(SchedulerTest, InOrderQueueCrossDepsShortcutFuncs) {

InOrderQueue.submit([&](sycl::handler &CGH) {
CGH.host_task([&] {
std::unique_lock lk(CvMutex);
std::unique_lock<std::mutex> lk(CvMutex);
Cv.wait(lk, [&ready] { return ready; });
});
});
Expand All @@ -156,7 +156,7 @@ TEST_F(SchedulerTest, InOrderQueueCrossDepsShortcutFuncs) {
event Ev2 = InOrderQueue.single_task<TestKernel<>>([] {});

{
std::unique_lock lk(CvMutex);
std::unique_lock<std::mutex> lk(CvMutex);
ready = true;
}
Cv.notify_one();
Expand All @@ -168,4 +168,4 @@ TEST_F(SchedulerTest, InOrderQueueCrossDepsShortcutFuncs) {
EXPECT_EQ(ExecutedCommands[0].second /*EventsCount*/, 0u);
EXPECT_EQ(ExecutedCommands[1].first /*CommandType*/, CommandType::KERNEL);
EXPECT_EQ(ExecutedCommands[1].second /*EventsCount*/, 0u);
}
}