[Bindless][Exp] Windows & DX12 interop. Semaphore ops can take values. #13860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following PI functions have been added to support importing various external handle types for both memory and semaphores: - `piextImportExternalMemory` - `piextImportExternalSemaphore` The following PI functions and their corresponding `pi2ur` functions are now deprecated: - `piextImportExternalSemaphoreOpaqueFD` - `piextMemImportOpaqueFD` All Vulkan tests have been updated to work on both Windows and Linux. Comments have been added to the Vulkan test files to make it easier to read and understand the code. Support has been added for interoperability of certain DirectX 12 resources, namely dedicated memory resources and fences. A test has been added that uses both functionalities. Support has been added for semaphore operations to take values passed by the user. The semaphore will either signal a given value, or wait for a value of the user's choice.
|
Associated UR PR: oneapi-src/unified-runtime#1639 |
JackAKirk
reviewed
May 21, 2024
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sycl/test-e2e/bindless_images/dx12_interop/read_write_unsampled.h
Outdated
Show resolved
Hide resolved
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
JackAKirk
reviewed
May 27, 2024
| @@ -1712,10 +1721,18 @@ descriptor struct. | |||
| ```cpp | |||
| namespace sycl::ext::oneapi::experimental { | |||
|
|
|||
| // Types of external semaphore handles | |||
| enum class external_semaphore_handle_type { | |||
| opaque_fd = 0, | |||
There was a problem hiding this comment.
not: You could maybe write that opaque_fd isn't supported on windows.
There was a problem hiding this comment.
I've added some minor notes to clarify that opaque_fd is only supported on linux based systems. I think going more into depth about which handle types are supported by which operating systems is beyond the scope of this document, and advanced users who want to use the interop APIs will have to know this already when exporting handles from third-party APIs before they even reach SYCL.
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
reviewed
Jun 17, 2024
There was a problem hiding this comment.
oneapi-src/unified-runtime#1639 has now been merged, please merge in the latest changes from the sycl branch, then update the UR repo/tag/comment as suggested.
kbenzie
approved these changes
Jun 18, 2024
JackAKirk
approved these changes
Jun 18, 2024
|
@intel/llvm-gatekeepers please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PI functions have been added to support importing various external handle types for both memory and semaphores:
piextImportExternalMemorypiextImportExternalSemaphoreThe following PI functions and their corresponding
pi2urfunctions are now deprecated:piextImportExternalSemaphoreOpaqueFDpiextMemImportOpaqueFDAll Vulkan tests have been updated to work on both Windows and Linux. Comments have been added to the Vulkan test files to make it easier to read and understand the code.
Support has been added for interoperability of certain DirectX 12 resources, namely dedicated memory resources and fences. A test has been added that uses both functionalities.
Support has been added for semaphore operations to take values passed by the user. The semaphore will either signal a given value, or wait for a value of the user's choice.