[UR] Make kernel launch global offset param optional. #18573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The offset is already deprecated so this will let sycl omit it entirely in the future, for now it simplifies some adapter code by allowing the check for whether we're working with an offset to happen once at the sycl level with subsequent checks being simple nullptr comparisons.
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
igchor
approved these changes
May 21, 2025
|
arc fails tracked by #18668 |
|
ping @intel/llvm-reviewers-runtime @intel/dpcpp-nativecpu-reviewers |
uditagarwal97
approved these changes
May 26, 2025
RossBrunton
approved these changes
May 27, 2025
coldav
approved these changes
May 28, 2025
|
The HIP fail isn't related to these changes #18722 @intel/llvm-gatekeepers please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The offset is already deprecated so this will let sycl omit it entirely in the future, for now it simplifies some adapter code by allowing the check for whether we're working with an offset to happen once at the sycl level with subsequent checks being simple nullptr comparisons.