[SYCL] [Graph] Fix print_graph #19181
Conversation
keyradical
force-pushed
the
konrad/FixPrintGraph
branch
from
939fe46 to
9b1fc15
Compare
- Correct extra underscore in preview changes guard for print_graph - Also restore WIN32 code for export of print_graph as a test
|
I've pushed some changes that should resolve the issues that were in CI for this PR as well as the original issue. @sarnex I understand that some of the CI runners are down right now, though I have tested these changes locally on windows and linux for the E2E and ABI tests, as well as for the pre-C++11 ABI on linux so I'm pretty confident this should fix the reported issues. Would you prefer to wait till next week to try and merge this once CI is all back up, or merge it sooner to try and fix the post-commit? I'd guess maybe the post-commit is also affected by CI problems so merging it now might not be worth it but not sure. |
|
Yeah like half of the machines are down due to some lab maintenance until Monday. Given the scope of the change I'll trust you :) |
Fixes #19177