From faec143e76cf8380171ee5ef88397a5938609dda Mon Sep 17 00:00:00 2001 From: "Li, Ian" Date: Wed, 2 Jul 2025 10:24:46 -0700 Subject: [PATCH 1/7] Move benchmarking out of sycl nightly --- .../workflows/sycl-nightly-benchmarking.yml | 54 +++++++++++++++++++ .github/workflows/sycl-nightly.yml | 29 ---------- 2 files changed, 54 insertions(+), 29 deletions(-) create mode 100644 .github/workflows/sycl-nightly-benchmarking.yml diff --git a/.github/workflows/sycl-nightly-benchmarking.yml b/.github/workflows/sycl-nightly-benchmarking.yml new file mode 100644 index 0000000000000..9ad2003dd6a6c --- /dev/null +++ b/.github/workflows/sycl-nightly-benchmarking.yml @@ -0,0 +1,54 @@ +name: SYCL Nightly Benchmarking + +on: + workflow_dispatch: + schedule: + - cron: '0 2 * * *' + +permissions: read-all + +jobs: + ubuntu2204_build: + if: github.repository == 'intel/llvm' + uses: ./.github/workflows/sycl-linux-build.yml + secrets: inherit + with: + build_cache_root: "/__w/" + build_artifact_suffix: default + build_configure_extra_args: '--hip --cuda --no-assertions' + build_image: ghcr.io/intel/llvm/ubuntu2204_build:latest + retention-days: 90 + + # We upload the build for people to download/use, override its name and + # prefer widespread gzip compression. + artifact_archive_name: sycl_linux.tar.gz + + run-sycl-benchmarks: + needs: [ubuntu2204_build] + if: ${{ always() && !cancelled() && needs.ubuntu2204_build.outputs.build_conclusion == 'success' }} + strategy: + fail-fast: false + matrix: + runner: ['["PVC_PERF"]', '["BMG_PERF"]'] + backend: ['level_zero:gpu', 'level_zero_v2:gpu'] + include: + - ref: ${{ github.sha }} + save_name: 'Baseline' + preset: 'Minimal' + uses: ./.github/workflows/sycl-linux-run-tests.yml + secrets: inherit + with: + name: Run compute-benchmarks (${{ matrix.runner }}, ${{ matrix.backend }}) + runner: ${{ matrix.runner }} + image: ghcr.io/intel/llvm/sycl_ubuntu2404_nightly:latest + image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN + target_devices: ${{ matrix.backend }} + tests_selector: benchmarks + benchmark_upload_results: true + benchmark_save_name: ${{ matrix.save_name }} + benchmark_preset: ${{ matrix.preset }} + repo_ref: ${{ matrix.ref }} + sycl_toolchain_artifact: sycl_linux_default + sycl_toolchain_archive: ${{ needs.ubuntu2204_build.outputs.artifact_archive_name }} + sycl_toolchain_decompress_command: ${{ needs.ubuntu2204_build.outputs.artifact_decompress_command }} + diff --git a/.github/workflows/sycl-nightly.yml b/.github/workflows/sycl-nightly.yml index d99e23044de91..61dfbde272864 100644 --- a/.github/workflows/sycl-nightly.yml +++ b/.github/workflows/sycl-nightly.yml @@ -280,35 +280,6 @@ jobs: sycl_toolchain_archive: ${{ needs.build-win.outputs.artifact_archive_name }} sycl_cts_artifact: sycl_cts_bin_win - run-sycl-benchmarks: - needs: [ubuntu2204_build] - if: ${{ always() && !cancelled() && needs.ubuntu2204_build.outputs.build_conclusion == 'success' }} - strategy: - fail-fast: false - matrix: - runner: ['["PVC_PERF"]', '["BMG_PERF"]'] - backend: ['level_zero:gpu', 'level_zero_v2:gpu'] - include: - - ref: ${{ github.sha }} - save_name: 'Baseline' - preset: 'Minimal' - uses: ./.github/workflows/sycl-linux-run-tests.yml - secrets: inherit - with: - name: Run compute-benchmarks (${{ matrix.runner }}, ${{ matrix.backend }}) - runner: ${{ matrix.runner }} - image: ghcr.io/intel/llvm/sycl_ubuntu2404_nightly:latest - image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN - target_devices: ${{ matrix.backend }} - tests_selector: benchmarks - benchmark_upload_results: true - benchmark_save_name: ${{ matrix.save_name }} - benchmark_preset: ${{ matrix.preset }} - repo_ref: ${{ matrix.ref }} - sycl_toolchain_artifact: sycl_linux_default - sycl_toolchain_archive: ${{ needs.ubuntu2204_build.outputs.artifact_archive_name }} - sycl_toolchain_decompress_command: ${{ needs.ubuntu2204_build.outputs.artifact_decompress_command }} - nightly_build_upload: name: Nightly Build Upload if: ${{ github.ref_name == 'sycl' }} From 269ca98ca131880a3f948874a4ccd6c7cd8c5a9f Mon Sep 17 00:00:00 2001 From: "Li, Ian" Date: Wed, 2 Jul 2025 10:29:02 -0700 Subject: [PATCH 2/7] Remove unapplicable comments --- .github/workflows/sycl-nightly-benchmarking.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/sycl-nightly-benchmarking.yml b/.github/workflows/sycl-nightly-benchmarking.yml index 9ad2003dd6a6c..d5a2d5c40ead3 100644 --- a/.github/workflows/sycl-nightly-benchmarking.yml +++ b/.github/workflows/sycl-nightly-benchmarking.yml @@ -18,9 +18,6 @@ jobs: build_configure_extra_args: '--hip --cuda --no-assertions' build_image: ghcr.io/intel/llvm/ubuntu2204_build:latest retention-days: 90 - - # We upload the build for people to download/use, override its name and - # prefer widespread gzip compression. artifact_archive_name: sycl_linux.tar.gz run-sycl-benchmarks: From c7f26ec084d7934dbed3c28b47c2c1c2ab933816 Mon Sep 17 00:00:00 2001 From: "Li, Ian" Date: Thu, 3 Jul 2025 08:37:12 -0700 Subject: [PATCH 3/7] Remove unnecessary flags --- .github/workflows/sycl-nightly-benchmarking.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/sycl-nightly-benchmarking.yml b/.github/workflows/sycl-nightly-benchmarking.yml index d5a2d5c40ead3..6f57c24403772 100644 --- a/.github/workflows/sycl-nightly-benchmarking.yml +++ b/.github/workflows/sycl-nightly-benchmarking.yml @@ -15,9 +15,8 @@ jobs: with: build_cache_root: "/__w/" build_artifact_suffix: default - build_configure_extra_args: '--hip --cuda --no-assertions' + build_configure_extra_args: '--no-assertions' build_image: ghcr.io/intel/llvm/ubuntu2204_build:latest - retention-days: 90 artifact_archive_name: sycl_linux.tar.gz run-sycl-benchmarks: From ac49668c010543c06f655bcb14f436e266d59e80 Mon Sep 17 00:00:00 2001 From: "Li, Ian" Date: Thu, 3 Jul 2025 09:09:20 -0700 Subject: [PATCH 4/7] [test] test configure args for compilation failure --- .github/workflows/sycl-nightly-benchmarking.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sycl-nightly-benchmarking.yml b/.github/workflows/sycl-nightly-benchmarking.yml index 6f57c24403772..91be081db87e6 100644 --- a/.github/workflows/sycl-nightly-benchmarking.yml +++ b/.github/workflows/sycl-nightly-benchmarking.yml @@ -15,7 +15,7 @@ jobs: with: build_cache_root: "/__w/" build_artifact_suffix: default - build_configure_extra_args: '--no-assertions' + build_configure_extra_args: '--hip --cuda' build_image: ghcr.io/intel/llvm/ubuntu2204_build:latest artifact_archive_name: sycl_linux.tar.gz From f07d7ed6293c88b29265afa2dc9638227bfdec88 Mon Sep 17 00:00:00 2001 From: "Li, Ian" Date: Thu, 3 Jul 2025 11:39:05 -0700 Subject: [PATCH 5/7] [test] add back --no-assertions --- .github/workflows/sycl-nightly-benchmarking.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sycl-nightly-benchmarking.yml b/.github/workflows/sycl-nightly-benchmarking.yml index 91be081db87e6..087642485e722 100644 --- a/.github/workflows/sycl-nightly-benchmarking.yml +++ b/.github/workflows/sycl-nightly-benchmarking.yml @@ -15,7 +15,7 @@ jobs: with: build_cache_root: "/__w/" build_artifact_suffix: default - build_configure_extra_args: '--hip --cuda' + build_configure_extra_args: '--hip --cuda --no-assertions' build_image: ghcr.io/intel/llvm/ubuntu2204_build:latest artifact_archive_name: sycl_linux.tar.gz From 964d01b006472fd87d7eb37da1c0195f60df89d9 Mon Sep 17 00:00:00 2001 From: "Li, Ian" Date: Thu, 3 Jul 2025 13:33:44 -0700 Subject: [PATCH 6/7] [test] remove compile args --- .github/workflows/sycl-nightly-benchmarking.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sycl-nightly-benchmarking.yml b/.github/workflows/sycl-nightly-benchmarking.yml index 087642485e722..c7287ad896ee7 100644 --- a/.github/workflows/sycl-nightly-benchmarking.yml +++ b/.github/workflows/sycl-nightly-benchmarking.yml @@ -15,7 +15,7 @@ jobs: with: build_cache_root: "/__w/" build_artifact_suffix: default - build_configure_extra_args: '--hip --cuda --no-assertions' + # build_configure_extra_args: '--no-assertions' build_image: ghcr.io/intel/llvm/ubuntu2204_build:latest artifact_archive_name: sycl_linux.tar.gz From 79d930de21ced8373af62065bfdd547095cd92f9 Mon Sep 17 00:00:00 2001 From: "Li, Ian" Date: Fri, 4 Jul 2025 09:53:36 -0700 Subject: [PATCH 7/7] Switch to Ubuntu 24.04 --- .github/workflows/sycl-nightly-benchmarking.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/sycl-nightly-benchmarking.yml b/.github/workflows/sycl-nightly-benchmarking.yml index c7287ad896ee7..09db781d05c56 100644 --- a/.github/workflows/sycl-nightly-benchmarking.yml +++ b/.github/workflows/sycl-nightly-benchmarking.yml @@ -15,8 +15,8 @@ jobs: with: build_cache_root: "/__w/" build_artifact_suffix: default - # build_configure_extra_args: '--no-assertions' - build_image: ghcr.io/intel/llvm/ubuntu2204_build:latest + build_configure_extra_args: '--no-assertions' + build_image: ghcr.io/intel/llvm/ubuntu2404_build:latest artifact_archive_name: sycl_linux.tar.gz run-sycl-benchmarks: