From 77a476eebfc3092dde5e8ca9c651e03638d43fa1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Patryk=20Kami=C5=84ski?= Date: Thu, 3 Jul 2025 01:36:10 +0000 Subject: [PATCH] [Benchmarks] Remove stdout field from results This field is not used anywhere in scripts nor in the dashboard. It was merely saved in the results objects in run json files and copied into data.json making the file significantly bigger. --- devops/scripts/benchmarks/benches/benchdnn.py | 1 - devops/scripts/benchmarks/benches/compute.py | 1 - devops/scripts/benchmarks/benches/gromacs.py | 2 -- devops/scripts/benchmarks/benches/llamacpp.py | 1 - devops/scripts/benchmarks/benches/syclbench.py | 1 - devops/scripts/benchmarks/benches/test.py | 1 - devops/scripts/benchmarks/benches/umf.py | 1 - devops/scripts/benchmarks/benches/velocity.py | 1 - devops/scripts/benchmarks/utils/result.py | 5 ++--- 9 files changed, 2 insertions(+), 12 deletions(-) diff --git a/devops/scripts/benchmarks/benches/benchdnn.py b/devops/scripts/benchmarks/benches/benchdnn.py index 774d6d348aa83..27f425328cd49 100644 --- a/devops/scripts/benchmarks/benches/benchdnn.py +++ b/devops/scripts/benchmarks/benches/benchdnn.py @@ -161,7 +161,6 @@ def run(self, env_vars): unit="ms", command=command, env=env_vars, - stdout=output, git_url=self.suite.git_url(), git_hash=self.suite.git_tag(), ) diff --git a/devops/scripts/benchmarks/benches/compute.py b/devops/scripts/benchmarks/benches/compute.py index 25631c288f951..bdd07b430f407 100644 --- a/devops/scripts/benchmarks/benches/compute.py +++ b/devops/scripts/benchmarks/benches/compute.py @@ -303,7 +303,6 @@ def run(self, env_vars) -> list[Result]: stddev=stddev, command=command, env=env_vars, - stdout=result, unit=parse_unit_type(unit), git_url=self.bench.git_url(), git_hash=self.bench.git_hash(), diff --git a/devops/scripts/benchmarks/benches/gromacs.py b/devops/scripts/benchmarks/benches/gromacs.py index 781f5ab16754e..a2eec1b496b03 100644 --- a/devops/scripts/benchmarks/benches/gromacs.py +++ b/devops/scripts/benchmarks/benches/gromacs.py @@ -15,7 +15,6 @@ class GromacsBench(Suite): - def git_url(self): return "https://gitlab.com/gromacs/gromacs.git" @@ -221,7 +220,6 @@ def run(self, env_vars): unit="s", command=command, env=env_vars, - stdout=mdrun_output, git_url=self.suite.git_url(), git_hash=self.suite.git_tag(), ) diff --git a/devops/scripts/benchmarks/benches/llamacpp.py b/devops/scripts/benchmarks/benches/llamacpp.py index d8eba11916a31..be2fe74c516a5 100644 --- a/devops/scripts/benchmarks/benches/llamacpp.py +++ b/devops/scripts/benchmarks/benches/llamacpp.py @@ -154,7 +154,6 @@ def run(self, env_vars) -> list[Result]: value=mean, command=command, env=env_vars, - stdout=result, unit="token/s", git_url=self.bench.git_url(), git_hash=self.bench.git_hash(), diff --git a/devops/scripts/benchmarks/benches/syclbench.py b/devops/scripts/benchmarks/benches/syclbench.py index be36c4cd7ba9a..ffb164e2ce7cd 100644 --- a/devops/scripts/benchmarks/benches/syclbench.py +++ b/devops/scripts/benchmarks/benches/syclbench.py @@ -165,7 +165,6 @@ def run(self, env_vars) -> list[Result]: passed=(row[1] == "PASS"), command=command, env=env_vars, - stdout=row, unit="ms", git_url=self.bench.git_url(), git_hash=self.bench.git_hash(), diff --git a/devops/scripts/benchmarks/benches/test.py b/devops/scripts/benchmarks/benches/test.py index 94fd76041a26f..bfc1cfcd55323 100644 --- a/devops/scripts/benchmarks/benches/test.py +++ b/devops/scripts/benchmarks/benches/test.py @@ -96,7 +96,6 @@ def run(self, env_vars) -> list[Result]: value=random_value, command=["test", "--arg1", "foo"], env={"A": "B"}, - stdout="no output", unit="ms", ) ] diff --git a/devops/scripts/benchmarks/benches/umf.py b/devops/scripts/benchmarks/benches/umf.py index 6af745e7de3cb..752d71f9b1a43 100644 --- a/devops/scripts/benchmarks/benches/umf.py +++ b/devops/scripts/benchmarks/benches/umf.py @@ -165,7 +165,6 @@ def run(self, env_vars) -> list[Result]: value=value, command=command, env=env_vars, - stdout=result, unit=self.get_unit_time_or_overhead(explicit_group), ) ) diff --git a/devops/scripts/benchmarks/benches/velocity.py b/devops/scripts/benchmarks/benches/velocity.py index 17e0d22331df2..d4ceae393144b 100644 --- a/devops/scripts/benchmarks/benches/velocity.py +++ b/devops/scripts/benchmarks/benches/velocity.py @@ -146,7 +146,6 @@ def run(self, env_vars) -> list[Result]: value=self.parse_output(result), command=command, env=env_vars, - stdout=result, unit=self.unit, git_url=self.vb.git_url(), git_hash=self.vb.git_hash(), diff --git a/devops/scripts/benchmarks/utils/result.py b/devops/scripts/benchmarks/utils/result.py index 174e67aeaf233..c25c2da128214 100644 --- a/devops/scripts/benchmarks/utils/result.py +++ b/devops/scripts/benchmarks/utils/result.py @@ -15,7 +15,6 @@ class Result: value: float command: list[str] env: dict[str, str] - stdout: str passed: bool = True unit: str = "" # stddev can be optionally set by the benchmark, @@ -36,8 +35,8 @@ class BenchmarkRun: name: str = "This PR" hostname: str = "Unknown" git_hash: str = "" - github_repo: str = None - date: datetime = field( + github_repo: str = "" + date: datetime | None = field( default=None, metadata=config(encoder=datetime.isoformat, decoder=datetime.fromisoformat), )