Skip to content

[SYCL][NFC] Code clean up revealed by self build. #2985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 12, 2021

Conversation

zahiraam
Copy link
Contributor

@zahiraam zahiraam commented Jan 4, 2021

No description provided.

kbobrovs
kbobrovs previously approved these changes Jan 6, 2021
Copy link
Contributor

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LowerESIMD.cpp LGTM

Comment on lines 1613 to 1615
if (GV->getInitializer()->getType() != SOVC->getType()) {
SOVC = ConstantExpr::getBitCast(SOVC, GV->getInitializer()->getType());

}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, commit this change to llorg instead of intel/llvm.
This part is not relevant to SYCL.

Copy link
Contributor Author

@zahiraam zahiraam Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the edit from file.

@bader bader merged commit b9f9fac into intel:sycl Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants