From 9e5eaff1ad0e62952a490294058e6d72b5bafa41 Mon Sep 17 00:00:00 2001 From: Vladimir Lazarev Date: Mon, 11 Jan 2021 11:16:51 +0300 Subject: [PATCH 1/3] [SYCL][Doc] Require put link to test PR in commit message --- CONTRIBUTING.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 225a43ae1ad7d..8c0cd1a0721be 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -62,6 +62,12 @@ see [ABI Policy Guide](sycl/doc/ABIPolicyGuide.md) for more information. - For any DPC++-related commit, the `[SYCL]` tag should be present in the commit message title. To a reasonable extent, additional tags can be used to signify the component changed, e.g.: `[PI]`, `[CUDA]`, `[Doc]`. +- For product changes which require modification of E2E tests + (see [Test DPC++ toolchain](sycl/doc/GetStartedGuide.md#test-dpc-toolchain)) + the commit message should contain link to corresponding test PR, e.g.: E2E + test changes are availbale under intel/llvm-test-suite#88. + See [Autolinked references and URLs](https://docs.github.com/en/free-pro-team/github/writing-on-github/autolinked-references-and-urls) + for more details. ### Review and acceptance testing From 6c2dc7f84f8622b21fe8dd4c6f676834feb83992 Mon Sep 17 00:00:00 2001 From: Vladimir Lazarev Date: Tue, 12 Jan 2021 08:36:01 +0300 Subject: [PATCH 2/3] Apply review comments --- CONTRIBUTING.md | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8c0cd1a0721be..28b9861d739ba 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -62,12 +62,14 @@ see [ABI Policy Guide](sycl/doc/ABIPolicyGuide.md) for more information. - For any DPC++-related commit, the `[SYCL]` tag should be present in the commit message title. To a reasonable extent, additional tags can be used to signify the component changed, e.g.: `[PI]`, `[CUDA]`, `[Doc]`. -- For product changes which require modification of E2E tests +- For product changes which require modification in tests outside current repo (see [Test DPC++ toolchain](sycl/doc/GetStartedGuide.md#test-dpc-toolchain)) the commit message should contain link to corresponding test PR, e.g.: E2E - test changes are availbale under intel/llvm-test-suite#88. - See [Autolinked references and URLs](https://docs.github.com/en/free-pro-team/github/writing-on-github/autolinked-references-and-urls) - for more details. + test changes are available under intel/llvm-test-suite#88 or SYCL + conformance test changes are available under KhronosGroup/SYCL-CTS#65 (see + [Autolinked references and URLs](https://docs.github.com/en/free-pro-team/github/writing-on-github/autolinked-references-and-urls) + for more details). The same message should be present both in commit + message and PR description. ### Review and acceptance testing From dfdb2afcb0025313cb4de5dd081b365723a62e8f Mon Sep 17 00:00:00 2001 From: vladimirlaz Date: Wed, 13 Jan 2021 08:07:18 +0300 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: Alexey Bader --- CONTRIBUTING.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 28b9861d739ba..03e363c191e7e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -62,14 +62,14 @@ see [ABI Policy Guide](sycl/doc/ABIPolicyGuide.md) for more information. - For any DPC++-related commit, the `[SYCL]` tag should be present in the commit message title. To a reasonable extent, additional tags can be used to signify the component changed, e.g.: `[PI]`, `[CUDA]`, `[Doc]`. -- For product changes which require modification in tests outside current repo - (see [Test DPC++ toolchain](sycl/doc/GetStartedGuide.md#test-dpc-toolchain)) - the commit message should contain link to corresponding test PR, e.g.: E2E +- For product changes which require modification in tests outside of the current repository + (see [Test DPC++ toolchain](sycl/doc/GetStartedGuide.md#test-dpc-toolchain)), + the commit message should contain the link to corresponding test PR, e.g.: E2E test changes are available under intel/llvm-test-suite#88 or SYCL conformance test changes are available under KhronosGroup/SYCL-CTS#65 (see [Autolinked references and URLs](https://docs.github.com/en/free-pro-team/github/writing-on-github/autolinked-references-and-urls) for more details). The same message should be present both in commit - message and PR description. + message and in PR description. ### Review and acceptance testing